linux-kernel - Re: [PATCH v2] staging: rtl8723bs: constify _action_public_str in rtw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2026020752-extortion-coleslaw-9687@gregkh>
Date: Sat, 7 Feb 2026 14:40:27 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Haroen Tmimi <tmimiharoen@...il.com>
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: rtl8723bs: constify _action_public_str in
 rtw_ieee80211.c

On Thu, Feb 05, 2026 at 01:09:09PM +0100, Haroen Tmimi wrote:
> Make the _action_public_str array "static const char * const".
> 
> This ensures the array entries are read-only, preventing accidental
> modification of the pointers.
> 
> Signed-off-by: Haroen Tmimi <tmimiharoen@...il.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> index 92b12a13d27c..febc14de6bc0 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> @@ -1139,7 +1139,7 @@ int rtw_action_frame_parse(const u8 *frame, u32 frame_len, u8 *category, u8 *act
>  	return true;
>  }
>  
> -static const char *_action_public_str[] = {
> +static const char * const _action_public_str[] = {
>  	"ACT_PUB_BSSCOEXIST",
>  	"ACT_PUB_DSE_ENABLE",
>  	"ACT_PUB_DSE_DEENABLE",
> -- 
> 2.53.0
> 
> 

Someone already sent this same change before you did, sorry.

Why all of the same fixes for the same driver are happening at once?
Did a class just happen that encouraged people to make these types of
changes to the driver?

thanks,

greg k-h