linux-kernel - Re: [PATCH 3/6] dt-bindings: iio: adc: adi,ad4080: add support for AD4085

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260207151028.1c4e110b@jic23-huawei>
Date: Sat, 7 Feb 2026 15:10:28 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Antoniu Miclaus <antoniu.miclaus@...log.com>, Lars-Peter Clausen
 <lars@...afoo.de>, Michael Hennerich <Michael.Hennerich@...log.com>, David
 Lechner <dlechner@...libre.com>, Nuno Sá
 <nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>, Rob Herring
 <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, linux-iio@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/6] dt-bindings: iio: adc: adi,ad4080: add support for
 AD4085

On Sat, 7 Feb 2026 11:52:57 +0100
Krzysztof Kozlowski <krzk@...nel.org> wrote:

> On Fri, Feb 06, 2026 at 03:08:22PM +0200, Antoniu Miclaus wrote:
> > Add device tree binding support for the AD4085 16-bit SAR ADC.
> > Add adi,ad4085 to the compatible enum.
> > 
> > A fallback compatible string to adi,ad4080 is not appropriate as the
> > AD4085 has a different LVDS CNV clock count maximum (8 vs 7), requiring
> > different driver configuration.
> > 
> > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@...log.com>
> > ---
> >  Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml | 1 +  
> 
> Squash the patches. You just added one line, but commit msg is 5 lines.
> Exactly copied from previous commit.

Squashing the driver changes as well into a single patch with all 3
new devices added seems sensible alongside squashing the DT.

The changes are all very similar across the 3 patches.

Jonathan

> 
> Best regards,
> Krzysztof
> 
>