linux-kernel - Re: [PATCH v6] scripts: checkpatch: move Rust-specific lints to separate file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72n+C1xU43ZjiAE35rx-NHWAOZyNHK0_kuYAGCpo4BkU_g@mail.gmail.com>
Date: Sat, 7 Feb 2026 17:07:23 +0100
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Jason Hall <jason.kei.hall@...il.com>
Cc: Joe Perches <joe@...ches.com>, Dirk Behme <dirk.behme@...bosch.com>, 
	Gary Guo <gary@...yguo.net>, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Miguel Ojeda <ojeda@...nel.org>
Subject: Re: [PATCH v6] scripts: checkpatch: move Rust-specific lints to
 separate file

On Sat, Feb 7, 2026 at 4:56 PM Jason Hall <jason.kei.hall@...il.com> wrote:
>
> Link: https://github.com/Rust-for-linux/linux/issues/1191

I guess the link doesn't hurt, but the link is a bit tangential for
this patch (unlike the other one, of course).

> -# (c) 2026, Jason K. Hall <jason.kei.hall@...il.com>
> +# (c) 2026, Jason Hall <jason.kei.hall@...il.com>

Unrelated change?

> -    # check for Rust unwrap/expect
> -    if ($line =~ /^\+/) {
> -        if ($line =~ /(?:\.|::)(?:unwrap|expect)\s*\(/ &&
> -            $rawline !~ /\/\/\s*PANIC:/ &&
> -            $line !~ /^\+\s*\/\// &&
> -            $line !~ /^\+\s*assert/) {
> -            return ("RUST_UNWRAP",
> -                    "Avoid unwrap() or expect() in Rust code; use proper error handling (Result) or justify with a '// PANIC: ...' comment.\n" . $herecurr);
> -        }
> -    }

This diff seems to be based on the previous patches. Each version of a
series should be a rebase, not a stack.

Thanks!

Cheers,
Miguel