[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20260207162930.353412f5@jic23-huawei>
Date: Sat, 7 Feb 2026 16:29:30 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Erikas Bitovtas <xerikasxx@...il.com>
Cc: David Lechner <dlechner@...libre.com>, Nuno Sá
<nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>, Rob Herring
<robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, Kevin Tsai <ktsai@...ellamicro.com>,
linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht,
phone-devel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: Add binding document for cm36686
On Sun, 01 Feb 2026 19:03:48 +0200
Erikas Bitovtas <xerikasxx@...il.com> wrote:
> Document the Capella cm36686 ambient light and proximity sensor devicetree
> bindings.
>
> Signed-off-by: Erikas Bitovtas <xerikasxx@...il.com>
One comment inline.
Thanks,
Jonathan
> ---
> .../bindings/iio/light/capella,cm36686.yaml | 74 ++++++++++++++++++++++
> 1 file changed, 74 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/light/capella,cm36686.yaml b/Documentation/devicetree/bindings/iio/light/capella,cm36686.yaml
> new file mode 100644
> index 000000000000..5f0a585e3d87
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/light/capella,cm36686.yaml
> @@ -0,0 +1,74 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/light/capella,cm36686.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Capella cm36686 I2C Ambient Light and Proximity sensor
> +
> +maintainers:
> + - Erikas Bitovtas <xerikasxx@...il.com>
> +
> +properties:
> + compatible:
> + enum:
> + - capella,cm36686
> + - capella,cm36672p
> +
> + reg:
> + maxItems: 1
> + description:
> + I2C slave address of the device. Must be 0x60 for both cm36686
Try to avoid the word slave in new docs
I2C address of the device ...
Is fine here.
> + and cm36672p sensors.
>
Powered by blists - more mailing lists