linux-kernel - Re: [PATCH v2 0/4] x86 suspend cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMzpN2jtAxPTEjsOSaub1k68cx0U++r6+bMAXVy24gudvTfwBg@mail.gmail.com>
Date: Sat, 7 Feb 2026 13:04:44 -0500
From: Brian Gerst <brgerst@...il.com>
To: Ard Biesheuvel <ardb@...nel.org>
Cc: linux-kernel@...r.kernel.org, x86@...nel.org, 
	Ingo Molnar <mingo@...nel.org>, "H . Peter Anvin" <hpa@...or.com>, Thomas Gleixner <tglx@...utronix.de>, 
	Borislav Petkov <bp@...en8.de>, "Rafael J . Wysocki" <rafael@...nel.org>, Len Brown <lenb@...nel.org>, 
	Pavel Machek <pavel@...nel.org>
Subject: Re: [PATCH v2 0/4] x86 suspend cleanups

On Wed, Feb 4, 2026 at 4:47 AM Ard Biesheuvel <ardb@...nel.org> wrote:
>
>
> On Tue, 3 Feb 2026, at 18:58, Brian Gerst wrote:
> > This patchset cleans up the do_suspend_lowlevel() function, removing
> > some leftover bits that are no longer necessary since it started
> > using the SMP trampoline to resune the kernel.
> >
> > v2:
> > - Reworked the first patch
> > - Added more cleanups
> >
> > Brian Gerst (4):
> >   x86/acpi/suspend: Remove indirect jump
> >   x86/acpi/suspend: Remove segment reloads on resume
> >   x86/acpi/suspend: Clean up stack usage
> >   x86/acpi/suspend: Remove redundant register saves
> >
>
> This all looks correct to me - the stack changes in patch #3 do result in the stack misalignment to be different than it was before, but it is still 8 byte aligned throughout, which is all we care about in the kernel IIRC?

Yes, the kernel uses 8-byte alignment (-mpreferred-stack-boundary=3)
instead of the default 16 for space savings.