linux-kernel - Re: [PATCH v2 next 01/11] tools/nolibc/printf: Change variable used for format chars from 'c' to 'ch'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aYeJlLKAKr-sDf0f@1wt.eu>
Date: Sat, 7 Feb 2026 19:51:00 +0100
From: Willy Tarreau <w@....eu>
To: david.laight.linux@...il.com
Cc: Thomas Weißschuh <linux@...ssschuh.net>,
        linux-kernel@...r.kernel.org, Cheng Li <lechain@...il.com>
Subject: Re: [PATCH v2 next 01/11] tools/nolibc/printf: Change variable used
 for format chars from 'c' to 'ch'

Hi David,

On Fri, Feb 06, 2026 at 07:11:11PM +0000, david.laight.linux@...il.com wrote:
> From: David Laight <david.laight.linux@...il.com>
> 
> This makes the code slightly easier to read because the variable
> stands out from the single character literals (especially 'c').

While I thought it was purely cosmetic and useless, I have to
admit that it eases reading of certain large "if" conditions.

> The following patches pretty much rewrite the function so the
> churn is limited.
> 
> Signed-off-by: David Laight <david.laight.linux@...il.com>

Acked-by: Willy Tarreau <w@....eu>

Willy