linux-kernel - Re: [PATCH] [PATCH] staging-next: most: dim2: convert pr_info/err/warn to dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DG8CHO8ROFOW.2SZIY8A9ABY13@gmail.com>
Date: Fri, 06 Feb 2026 19:40:02 -0600
From: "Ethan Tidmore" <ethantidmore06@...il.com>
To: "Zeeshan Ahmad" <zeeshanahmad022019@...il.com>, "Parthiban Veerasooran"
 <parthiban.veerasooran@...rochip.com>, "Christian Gromm"
 <christian.gromm@...rochip.com>, "Greg Kroah-Hartman"
 <gregkh@...uxfoundation.org>
Cc: "Dan Carpenter" <dan.carpenter@...aro.org>, "Ethan Tidmore"
 <ethantidmore06@...il.com>, <linux-staging@...ts.linux.dev>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] [PATCH] staging-next: most: dim2: convert
 pr_info/err/warn to dev_info/err/warn

On Fri Feb 6, 2026 at 5:35 PM CST, Zeeshan Ahmad wrote:
> Note: This is a re-submission of a previous patch sent with an incorrect CC.
> Please consider this the correct submission.

This line is over 75 characters which breaks linux kernel coding style.
Use "$ ./scripts/checkpatch.pl --strict <patch>" from now on before
sending your patch off to catch things like this. Also, this note
belongs in your v2 changes below the "---".

>
> The dim2 driver currently uses generic pr_* logging macros. Hardware
> drivers should use the device-specific dev_* logging macros to provide
> better context in the system logs, especially in systems with multiple
> controller instances.
>
> This patch converts all applicable logging calls in dim2.c to use the
> proper device-specific APIs.
>
> Note: This patch is rebased on the current staging-next branch.
> It was previously submitted against master.

This should also be below the "---" in v2 changes.

>
> Signed-off-by: Zeeshan Ahmad <zeeshanahmad022019@...il.com>
> ---

Your header begins with "[PATCH] [PATCH]" [PATCH] should only happen
once and since it appears this is your v2 it should have been [PATCH
v2]. Also, you used "staging-next:" I guess you were using the branch
name but, the correct way to do it is just "staging:".

Please visit Dan Carpenter's guide on submitting a v2: (but this next
one will be your v3)
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

Thanks,

ET