linux-kernel - Re: [PATCH] tof: Add VL53L4CX TOF drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD++jLmTJBct_+HW3S7D6mSFeXE_ma5gj8HRakDgy9PWre0rLw@mail.gmail.com>
Date: Sat, 7 Feb 2026 22:41:15 +0100
From: Linus Walleij <linusw@...nel.org>
To: Jonathan Cameron <jic23@...nel.org>
Cc: 434779359@...com, David Lechner <dlechner@...libre.com>, 
	Nuno Sá <nuno.sa@...log.com>, 
	Andy Shevchenko <andy@...nel.org>, Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, 
	Bartosz Golaszewski <brgl@...nel.org>, liufulin <frank.liu@...ot.com>, 
	Waqar Hameed <waqar.hameed@...s.com>, linux-kernel@...r.kernel.org, 
	linux-iio@...r.kernel.org, linux-gpio@...r.kernel.org
Subject: Re: [PATCH] tof: Add VL53L4CX TOF drivers

On Sat, Feb 7, 2026 at 2:50 PM Jonathan Cameron <jic23@...nel.org> wrote:
> 434779359@...com wrote:

> > +#include <linux/of_gpio.h>
>
> Whilst I haven't checked yet it would be very usual to need
> to include of_gpio.h in an IIO driver. That may imply using wrong
> level of interfaces or just a stray include.

This is a legacy header that should not be used in new
code.

<linux/gpio/consumer.h> should suffice for consumers,
<linux/gpio/driver.h> should suffice for producers.

Yours,
Linus Walleij