linux-kernel - Re: [PATCH v5 3/3] gpio: brcmstb: allow parent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD++jLmkV3wNe2Wxj2VNOXNBN9UgAY2cXQOQkUynQHY8diGrfw@mail.gmail.com>
Date: Sat, 7 Feb 2026 22:47:01 +0100
From: Linus Walleij <linusw@...nel.org>
To: Florian Fainelli <florian.fainelli@...adcom.com>
Cc: linux-kernel@...r.kernel.org, Doug Berger <opendmb@...il.com>, 
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, 
	Bartosz Golaszewski <brgl@...nel.org>, Andy Shevchenko <andy.shevchenko@...il.com>, 
	Christophe Leroy <chleroy@...nel.org>, 
	"open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>, 
	"moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v5 3/3] gpio: brcmstb: allow parent_irq to wake

On Wed, Feb 4, 2026 at 5:43 PM Florian Fainelli
<florian.fainelli@...adcom.com> wrote:

> From: Doug Berger <opendmb@...il.com>
>
> The classic parent_wake_irq can only occur after the system has
> been placed into a hardware managed power management state. This
> prevents its use for waking from software managed suspend states
> like s2idle.
>
> By allowing the parent_irq to be enabled for wake enabled GPIO
> during suspend, these GPIO can now be used to wake from these
> states. The 'suspended' boolean is introduced to support wake
> event accounting.
>
> Signed-off-by: Doug Berger <opendmb@...il.com>
> [florian: port changes after generic gpio chip conversion]
> Signed-off-by: Florian Fainelli <florian.fainelli@...adcom.com>

This looks correct as far as I can understand.
I wish all GPIO drivers has as elaborate wakeup handling...
I will look at this driver to see how it should be done properly.

Reviewed-by: Linus Walleij <linusw@...nel.org>

Yours,
Linus Walleij