linux-kernel - Re: [PATCH] staging: rtl8723bs: clean up checkpatch warnings in rtw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DG933PFQ8WC8.T2CFFOKHSDDX@gmail.com>
Date: Sat, 07 Feb 2026 16:31:18 -0600
From: "Ethan Tidmore" <ethantidmore06@...il.com>
To: "Azamat Rakhim" <azamatrakhim8@...il.com>, <gregkh@...uxfoundation.org>
Cc: <karanja99erick@...il.com>, <linux-staging@...ts.linux.dev>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: rtl8723bs: clean up checkpatch warnings in
 rtw_btcoex.c

On Sat Feb 7, 2026 at 3:01 PM CST, Azamat Rakhim wrote:
> Remove unnecessary comparison to true and extra blank lines
> to address checkpatch warnings.
>
> Signed-off-by: Azamat Rakhim <azamatrakhim8@...il.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_btcoex.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_btcoex.c b/drivers/staging/rtl8723bs/core/rtw_btcoex.c
> index f4b19ef7b341..8c17ac994bbc 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_btcoex.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_btcoex.c
> @@ -11,7 +11,7 @@
>  void rtw_btcoex_MediaStatusNotify(struct adapter *padapter, u8 media_status)
>  {
>  	if ((media_status == RT_MEDIA_CONNECT)
> -		&& (check_fwstate(&padapter->mlmepriv, WIFI_AP_STATE) == true)) {
> +		&& (check_fwstate(&padapter->mlmepriv, WIFI_AP_STATE))) {
>  		rtw_hal_set_hwreg(padapter, HW_VAR_DL_RSVD_PAGE, NULL);
>  	}

You fixed one checkpatch.pl error on this line, but left another one.
Logical operators need to go at the end of the previous line
not the beginning of it. So that'd be "if ((media_status ==
RT_MEDIA_CONNECT) &&".

>  
> @@ -54,7 +54,6 @@ void rtw_btcoex_LPS_Enter(struct adapter *padapter)
>  	struct pwrctrl_priv *pwrpriv;
>  	u8 lps_val;
>  
> -
>  	pwrpriv = adapter_to_pwrctl(padapter);
>  
>  	pwrpriv->bpower_saving = true;
> @@ -66,7 +65,6 @@ void rtw_btcoex_LPS_Leave(struct adapter *padapter)
>  {
>  	struct pwrctrl_priv *pwrpriv;
>  
> -
>  	pwrpriv = adapter_to_pwrctl(padapter);
>  
>  	if (pwrpriv->pwr_mode != PS_MODE_ACTIVE) {

These whitespace fixes should be their own patch. Please keep one
logical change per patch.

Also, your subject line should say what you fixed not the tool you used to
find it. Next time before sending patches off run "$
./scripts/checkpatch.pl --strict <patch>" to find problems like this.

Thanks,

ET