linux-kernel - Re: [v4,net-next,01/11] net/nebula-matrix: add minimum nbl build framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260207022434.4017684-1-kuba@kernel.org>
Date: Fri,  6 Feb 2026 18:24:34 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: illusion.wang@...ula-matrix.com
Cc: Jakub Kicinski <kuba@...nel.org>,
	sam.chen@...ula-matrix.com,
	lukas.bulwahn@...hat.com,
	dimon.zhao@...ula-matrix.com,
	netdev@...r.kernel.org,
	vadim.fedorenko@...ux.dev,
	linux-kernel@...r.kernel.org (open list),
	corbet@....net,
	lorenzo@...nel.org,
	alvin.wang@...ula-matrix.com,
	andrew+netdev@...n.ch,
	linux-doc@...r.kernel.org,
	pabeni@...hat.com,
	edumazet@...gle.com,
	horms@...nel.org
Subject: Re: [v4,net-next,01/11] net/nebula-matrix: add minimum nbl build framework

This is an AI-generated review of your patch. The human sending this
email says "This is an automated AI code reviewer, please treat what
it says with a grain of salt."

For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html
---
net/nebula-matrix: add minimum nbl build framework

This commit adds the minimal build infrastructure for the Nebula-Matrix
M18100-NIC family driver, including Kconfig, Makefiles, documentation,
and stub PCI driver functions.

> diff --git a/Documentation/networking/device_drivers/ethernet/index.rst b/Documentation/networking/device_drivers/ethernet/index.rst
> --- a/Documentation/networking/device_drivers/ethernet/index.rst
> +++ b/Documentation/networking/device_drivers/ethernet/index.rst
> @@ -48,6 +48,7 @@
>    meta/fbnic
>    microsoft/netvsc
>    mucse/rnpgbe
> +   nebula-matrix/nbl
>    netronome/nfp

The documentation index references 'nebula-matrix/nbl' but the actual file
created is 'nebula-matrix/m18100.rst'. This will cause 'make htmldocs' to fail
with a broken reference.

Simon Horman flagged this in v3 review:
https://lore.kernel.org/netdev/aXj_f3hsMmvKxC26@horms.kernel.org/

Should this be 'nebula-matrix/m18100' instead?

> diff --git a/drivers/net/ethernet/nebula-matrix/Kconfig b/drivers/net/ethernet/nebula-matrix/Kconfig
> --- /dev/null
> +++ b/drivers/net/ethernet/nebula-matrix/Kconfig

[ ... ]

> +config NBL_CORE
> +	tristate "Nebula-matrix Ethernet Controller m18100 Family support"

Andrew Lunn raised concerns about the NBL_CORE naming in multiple versions of
this patch series. The "_CORE" suffix is typically reserved for libraries shared
by multiple drivers that use 'select' rather than having a tristate prompt.

If this module provides Ethernet functionality directly, the naming convention
would be to call it an Ethernet driver rather than "core".

See v1 and v3 review comments:
https://lore.kernel.org/netdev/88c7e349-f941-4216-89ca-70a49e82b378@lunn.ch/

Is there a reason to keep the _CORE suffix, or could this follow standard driver
naming conventions?