linux-kernel - Re: [net-next,v13,2/4] net: dsa: add tag format for MxL862xx switches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260206184627.774c7f71@kernel.org>
Date: Fri, 6 Feb 2026 18:46:27 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Daniel Golle <daniel@...rotopia.org>
Cc: netdev@...r.kernel.org, andrew@...n.ch, davem@...emloft.net,
 conor+dt@...nel.org, krzk+dt@...nel.org, chad@...roe.io,
 devicetree@...r.kernel.org, lxu@...linear.com, frankwu@....de,
 linux@...linux.org.uk, john@...ozen.org, robh@...nel.org,
 cezary.wilmanski@...ran.com, hkallweit1@...il.com, horms@...nel.org,
 edumazet@...gle.com, linux-kernel@...r.kernel.org, pabeni@...hat.com,
 olteanv@...il.com
Subject: Re: [net-next,v13,2/4] net: dsa: add tag format for MxL862xx
 switches

On Fri, 6 Feb 2026 03:30:30 +0000 Daniel Golle wrote:
> > > +
> > > +	/* provide additional space 'MXL862_HEADER_LEN' bytes */
> > > +	skb_push(skb, MXL862_HEADER_LEN);  
> > 
> > [ ... ]
> >   
> > > +	dsa_alloc_etype_header(skb, MXL862_HEADER_LEN);
> > > +
> > > +	/* special tag ingress */  
> >                       ^^^^^^^
> > 
> > This comment says "ingress" but mxl862_tag_xmit() is the TX/egress path.
> > Should this say "egress" instead?  
> 
> "ingress" is the perspective of the switch, and how the tag to be used
> to send frames from the host to the switch is called in the datasheet[1]

Maybe expand on the comment a bit? Or remove it?
Cause reading the code I was also consued why this is called ingress