linux-kernel - Re: [PATCH] staging: vme_user: reorder NULL check after kzalloc in fake_crcsr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2026020835-flakily-grasp-9f39@gregkh>
Date: Sun, 8 Feb 2026 07:35:12 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Artem Lytkin <iprintercanon@...il.com>
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: vme_user: reorder NULL check after kzalloc in
 fake_crcsr_init

On Sat, Feb 07, 2026 at 09:55:02PM +0000, Artem Lytkin wrote:
> Move the NULL check for bridge->crcsr_kernel before its use in
> fake_ptr_to_pci(). While fake_ptr_to_pci() is a simple cast that
> handles NULL safely, using a value before validating it is a bad
> pattern that static analyzers flag and could become a real issue
> if fake_ptr_to_pci() changes in the future.
> 
> Signed-off-by: Artem Lytkin <iprintercanon@...il.com>
> ---
>  drivers/staging/vme_user/vme_fake.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/vme_user/vme_fake.c b/drivers/staging/vme_user/vme_fake.c
> index 731fbba17..506bc5439 100644
> --- a/drivers/staging/vme_user/vme_fake.c
> +++ b/drivers/staging/vme_user/vme_fake.c
> @@ -1029,9 +1029,9 @@ static int fake_crcsr_init(struct vme_bridge *fake_bridge)
>  
>  	/* Allocate mem for CR/CSR image */
>  	bridge->crcsr_kernel = kzalloc(VME_CRCSR_BUF_SIZE, GFP_KERNEL);
> -	bridge->crcsr_bus = fake_ptr_to_pci(bridge->crcsr_kernel);
>  	if (!bridge->crcsr_kernel)
>  		return -ENOMEM;
> +	bridge->crcsr_bus = fake_ptr_to_pci(bridge->crcsr_kernel);

As this isn't actually a bugfix, and if an automated tool can't handle
something as simple as this it's really broken, I think we should just
leave this alone for now.

thanks,

greg k-h