linux-kernel - Re: [PATCH v4] iio: magnetometer: bmc150_magn: cleanup mutex usage and coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aYiNcWJyCl71FyEa@smile.fi.intel.com>
Date: Sun, 8 Feb 2026 15:19:45 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Neel Bullywon <neelb2403@...il.com>
Cc: Jonathan Cameron <jic23@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Nuno Sá <nuno.sa@...log.com>,
	Andy Shevchenko <andy@...nel.org>, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] iio: magnetometer: bmc150_magn: cleanup mutex usage
 and coding style

On Fri, Feb 06, 2026 at 12:18:14PM -0500, Neel Bullywon wrote:
> Replace manual mutex lock/unlock calls with guard() to simplify error
> 
> handling and reduce goto usage. This ensures RAII-style cleanup where
> 
> the mutex is always released automatically.
> 
> Replace msleep(5) with usleep_range(5000, 6000) to avoid checkpatch
> 
> warnings about short msleep delays.
> 
> Also fix several indentation and line wrapping style issues to verify
> 
> cleanly with checkpatch.

You commit message is interleaved with unneeded blank lines. Something is wrong
on your side.

> Signed-off-by: Neel Bullywon <neelb2403@...il.com>
> ---
> Changes in v4:
> - Replace scoped_guard() with guard() to avoid lexical scope issues with goto
>   and return values which caused logic errors in previous versions.
> - Replace msleep(5) with usleep_range(5000, 6000) to avoid checkpatch
>   warning.

No, please, fix checkpatch first, it should suggest fsleep() and that is
what you should use.

> - Fix indentation and line wrapping to cleanliness.
> - Extend guard() usage to all mutex_lock() instances in the driver.

-- 
With Best Regards,
Andy Shevchenko