linux-kernel - Re: [PATCH] staging: rtl8723bs: fix inconsistent indentation detected by smatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2026020802-transform-ducking-ea25@gregkh>
Date: Sun, 8 Feb 2026 17:11:28 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Filippo Muscherà <filippo.muschera@...il.com>
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
	b9788213@...il.com, straube.linux@...il.com
Subject: Re: [PATCH] staging: rtl8723bs: fix inconsistent indentation
 detected by smatch

On Sun, Feb 08, 2026 at 04:47:34PM +0100, Filippo Muscherà wrote:
> Fix the following inconsistent indentation warnings reported by Smatch:
> 
> drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c:2319
>   EXhalbtc8723b1ant_ConnectNotify(): inconsistent indenting
> drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c:1410
>   phy_IQCalibrate_8723B(): inconsistent indenting
> 
> The affected code used a mix of tabs and spaces or excessive
> indentation, making it misleading to read. Align the lines with the
> surrounding code using tabs.
> 
> While at it, wrap long lines in HalPhyRf_8723B.c to silence checkpatch
> warnings.
> 
> Signed-off-by: Filippo Muscherà <filippo.muschera@...il.com>
> ---
>  drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c | 2 +-
>  drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c  | 6 ++++--
>  2 files changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c b/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c
> index b3d7f50fac4c..1af101ba9752 100644
> --- a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c
> +++ b/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c
> @@ -2316,7 +2316,7 @@ void EXhalbtc8723b1ant_ConnectNotify(struct btc_coexist *pBtCoexist, u8 type)
>  
>  	if (type == BTC_ASSOCIATE_START) {
>  		pCoexSta->bWiFiIsHighPriTask = true;
> -		 pCoexDm->nArpCnt = 0;
> +		pCoexDm->nArpCnt = 0;
>  	} else {
>  		pCoexSta->bWiFiIsHighPriTask = false;
>  		/* pCoexDm->nArpCnt = 0; */
> diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
> index 9df3274c1048..efa5faf9ffdf 100644
> --- a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
> +++ b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
> @@ -1407,8 +1407,10 @@ static void phy_IQCalibrate_8723B(
>  			PHY_SetBBReg(pDM_Odm->Adapter, rFPGA0_IQK, bMaskH3Bytes, 0x000000);
>  			pDM_Odm->RFCalibrateInfo.TxLOK[RF_PATH_A] = PHY_QueryRFReg(pDM_Odm->Adapter, RF_PATH_A, 0x8, bRFRegOffsetMask);
>  
> -				result[t][0] = (PHY_QueryBBReg(pDM_Odm->Adapter, rTx_Power_Before_IQK_A, bMaskDWord)&0x3FF0000)>>16;
> -				result[t][1] = (PHY_QueryBBReg(pDM_Odm->Adapter, rTx_Power_After_IQK_A, bMaskDWord)&0x3FF0000)>>16;
> +			result[t][0] = (PHY_QueryBBReg(pDM_Odm->Adapter, rTx_Power_Before_IQK_A, 
> +										   bMaskDWord) & 0x3FF0000) >> 16;
> +			result[t][1] = (PHY_QueryBBReg(pDM_Odm->Adapter, rTx_Power_After_IQK_A, 
> +										   bMaskDWord) & 0x3FF0000) >> 16;

You just added coding style issues here :(

Always run your patch through checkpatch.pl before sending it.

thanks,

greg k-h