linux-kernel - RE: [PATCH 2/4] irqchip/ast2700-intcx: Add AST2700 INTC0/INTC1 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <TY2PPF5CB9A1BE694EF0F82A274A441D252F264A@TY2PPF5CB9A1BE6.apcprd06.prod.outlook.com>
Date: Sun, 8 Feb 2026 02:27:14 +0000
From: Ryan Chen <ryan_chen@...eedtech.com>
To: Thomas Gleixner <tglx@...utronix.de>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
	Joel Stanley <joel@....id.au>, Andrew Jeffery <andrew@...econstruct.com.au>,
	Paul Walmsley <pjw@...nel.org>, Palmer Dabbelt <palmer@...belt.com>, Albert
 Ou <aou@...s.berkeley.edu>, Alexandre Ghiti <alex@...ti.fr>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-aspeed@...ts.ozlabs.org"
	<linux-aspeed@...ts.ozlabs.org>, "linux-riscv@...ts.infradead.org"
	<linux-riscv@...ts.infradead.org>
Subject: RE: [PATCH 2/4] irqchip/ast2700-intcx: Add AST2700 INTC0/INTC1
 support

> Subject: RE: [PATCH 2/4] irqchip/ast2700-intcx: Add AST2700 INTC0/INTC1
> support
> 
> On Sat, Feb 07 2026 at 03:50, Ryan Chen wrote:
> >> -----Original Message-----
> >> From: Thomas Gleixner <tglx@...utronix.de>
> >> Sent: Friday, February 6, 2026 7:34 PM
> >> To: Ryan Chen <ryan_chen@...eedtech.com>; Rob Herring
> >> <robh@...nel.org>; Krzysztof Kozlowski <krzk+dt@...nel.org>; Conor
> >> Dooley <conor+dt@...nel.org>; Joel Stanley <joel@....id.au>; Andrew
> >> Jeffery <andrew@...econstruct.com.au>; Paul Walmsley
> >> <pjw@...nel.org>; Palmer Dabbelt <palmer@...belt.com>; Albert Ou
> >> <aou@...s.berkeley.edu>; Alexandre Ghiti <alex@...ti.fr>
> >> Cc: linux-kernel@...r.kernel.org; devicetree@...r.kernel.org;
> >> linux-arm-kernel@...ts.infradead.org; linux-aspeed@...ts.ozlabs.org;
> >> linux-riscv@...ts.infradead.org; Ryan Chen <ryan_chen@...eedtech.com>
> >> Subject: Re: [PATCH 2/4] irqchip/ast2700-intcx: Add AST2700
> >> INTC0/INTC1 support
> 
> Please fix your email client to not copy all mail headers. If you can't fix it,
> remove them manually and replace it with the usual:

Sorry, This is my mistake. 
> 
> On Fri, Feb 06 2026 at ...., Thomas Gleixner wrote:
> >> > +	guard(raw_spinlock_irqsave)(&intc0->intc_lock);
> >>
> >> s/_irqsave// Interrupts are disabled when this is invoked.
> > Sorry, do you mean when this function been call.
> > Ther have desc->lock to do the raw_spin_lock_irqsave.
> 
> The core always holds irq_desc::lock with interrupts disabled when it invokes
> those irqchip callbacks. So trying to disable interrupts in them again is a
> pointless exercise.
> 
Thanks your gyudabce , understood.