[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f0d78b66-4022-4b65-ad38-86daec39bc7e@rowland.harvard.edu>
Date: Sun, 8 Feb 2026 16:32:56 -0500
From: Alan Stern <stern@...land.harvard.edu>
To: syzbot <syzbot+25ba18e2c5040447585d@...kaller.appspotmail.com>
Cc: greearb@...delatech.com, hdanton@...a.com, linux-kernel@...r.kernel.org,
linux-usb@...r.kernel.org, michal.pecio@...il.com, oneukum@...e.com,
syzkaller-bugs@...glegroups.com
Subject: Re: [syzbot] [usb?] INFO: task hung in usb_bulk_msg (2)
On Sun, Feb 08, 2026 at 12:34:02PM -0800, syzbot wrote:
> Hello,
>
> syzbot has tested the proposed patch but the reproducer is still triggering an issue:
> INFO: task hung in usb_bulk_msg
Okay, I've got an idea about what's going wrong. There's even a comment
warning about this in the source code. Let's see if the idea is right.
Alan Stern
#syz test: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git da87d45b1951
Index: usb-devel/drivers/usb/class/usbtmc.c
===================================================================
--- usb-devel.orig/drivers/usb/class/usbtmc.c
+++ usb-devel/drivers/usb/class/usbtmc.c
@@ -1347,6 +1347,8 @@ static int send_request_dev_dep_msg_in(s
buffer[11] = 0; /* Reserved */
/* Send bulk URB */
+ dev_info(&data->intf->dev, "Timeout set to %d\n",
+ file_data->timeout);
retval = usb_bulk_msg(data->usb_dev,
usb_sndbulkpipe(data->usb_dev,
data->bulk_out),
@@ -1362,7 +1364,6 @@ static int send_request_dev_dep_msg_in(s
data->bTag++;
kfree(buffer);
- if (retval < 0)
dev_err(&data->intf->dev, "%s returned %d\n",
__func__, retval);
@@ -1404,7 +1405,7 @@ static ssize_t usbtmc_read(struct file *
if (count > INT_MAX)
count = INT_MAX;
- dev_dbg(dev, "%s(count:%zu)\n", __func__, count);
+ dev_info(dev, "%s(count:%zu)\n", __func__, count);
retval = send_request_dev_dep_msg_in(file_data, count);
@@ -1425,7 +1426,7 @@ static ssize_t usbtmc_read(struct file *
buffer, bufsize, &actual,
file_data->timeout);
- dev_dbg(dev, "%s: bulk_msg retval(%u), actual(%d)\n",
+ dev_info(dev, "%s: bulk_msg retval(%u), actual(%d)\n",
__func__, retval, actual);
/* Store bTag (in case we need to abort) */
@@ -1470,7 +1471,7 @@ static ssize_t usbtmc_read(struct file *
file_data->bmTransferAttributes = buffer[8];
- dev_dbg(dev, "Bulk-IN header: N_characters(%u), bTransAttr(%u)\n",
+ dev_info(dev, "Bulk-IN header: N_characters(%u), bTransAttr(%u)\n",
n_characters, buffer[8]);
if (n_characters > remaining) {
Index: usb-devel/drivers/usb/gadget/udc/dummy_hcd.c
===================================================================
--- usb-devel.orig/drivers/usb/gadget/udc/dummy_hcd.c
+++ usb-devel/drivers/usb/gadget/udc/dummy_hcd.c
@@ -762,8 +762,13 @@ static int dummy_dequeue(struct usb_ep *
ep = usb_ep_to_dummy_ep(_ep);
dum = ep_to_dummy(ep);
- if (!dum->driver)
+ if (!dum->driver) {
+ dev_info(udc_dev(dum), "Got dequeue, no driver\n");
return -ESHUTDOWN;
+ }
+ dev_info(udc_dev(dum),
+ "dequeuing req %p from %s, len %d buf %p\n",
+ req, _ep->name, _req->length, _req->buf);
spin_lock_irqsave(&dum->lock, flags);
list_for_each_entry(iter, &ep->queue, queue) {
@@ -777,12 +782,14 @@ static int dummy_dequeue(struct usb_ep *
}
if (retval == 0) {
- dev_dbg(udc_dev(dum),
+ dev_info(udc_dev(dum),
"dequeued req %p from %s, len %d buf %p\n",
req, _ep->name, _req->length, _req->buf);
spin_unlock(&dum->lock);
usb_gadget_giveback_request(_ep, _req);
spin_lock(&dum->lock);
+ } else {
+ dev_info(udc_dev(dum), "request not found\n");
}
spin_unlock_irqrestore(&dum->lock, flags);
return retval;
Index: usb-devel/drivers/usb/core/message.c
===================================================================
--- usb-devel.orig/drivers/usb/core/message.c
+++ usb-devel/drivers/usb/core/message.c
@@ -57,15 +57,21 @@ static int usb_start_wait_urb(struct urb
urb->context = &ctx;
urb->actual_length = 0;
retval = usb_submit_urb(urb, GFP_NOIO);
- if (unlikely(retval))
+ if (unlikely(retval)) {
+ dev_info(&urb->dev->dev, "Submission failed on ep%d\n",
+ usb_endpoint_num(&urb->ep->desc));
goto out;
+ }
expire = timeout ? msecs_to_jiffies(timeout) : MAX_SCHEDULE_TIMEOUT;
if (!wait_for_completion_timeout(&ctx.done, expire)) {
+ dev_info(&urb->dev->dev, "Killing URB on ep%d\n",
+ usb_endpoint_num(&urb->ep->desc));
+
usb_kill_urb(urb);
retval = (ctx.status == -ENOENT ? -ETIMEDOUT : ctx.status);
- dev_dbg(&urb->dev->dev,
+ dev_info(&urb->dev->dev,
"%s timed out on ep%d%s len=%u/%u\n",
current->comm,
usb_endpoint_num(&urb->ep->desc),
Powered by blists - more mailing lists