linux-kernel - Re: [PATCH v2] arm64: dts: qcom: sm8550: Fix DTBO boot failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <73mvlkbwem3rt7kd6udyenazfufgb4zkt2kggiihihincjc6ry@53ztcljmqxnd>
Date: Sun, 8 Feb 2026 16:59:54 -0600
From: Bjorn Andersson <andersson@...nel.org>
To: webgeek1234@...il.com
Cc: Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Kumar Sharma <quic_vksharma@...cinc.com>, linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Pavan Kondeti <pavan.kondeti@....qualcomm.com>
Subject: Re: [PATCH v2] arm64: dts: qcom: sm8550: Fix DTBO boot failure

On Sat, Feb 07, 2026 at 07:16:03PM -0600, Aaron Kling via B4 Relay wrote:
> From: Pavan Kondeti <pavan.kondeti@....qualcomm.com>
> 
> ABL requires certain things in the base dtb to apply a dtbo.

What if I don't need/want a dtbo? Or are you referring to some specific
overlay that ABL attempts to apply?

> Namely:
> 
> * A label named qcom_tzlog must exist, but doesn't have to contain any
>   specific properties
> * The timer node must have a label named arch_timer
> 
> This aligns the sm8550 soc dtsi with those requirements. Without these
> in the base dtb, when ABL attempts to apply any dtbo, it will fail to
> the bootloader menu.
> 

I don't consider this to be a property of the SM8550 SoC, but rather
ABL shipping on specific devices - where ABL can't be replaced/fixed.

It's been a while since I booted SM8550 with the unmodified ABL (as I
always use abl2esp these days), but I don't remember having this problem
on the MTP...

Can we push this down to those specific devices that manifest this
problem and does not allow replacing ABL?

> Co-authored-by: Aaron Kling <webgeek1234@...il.com>
> Signed-off-by: Aaron Kling <webgeek1234@...il.com>
> ---
> With a current mainline sm8550 base dtb, ABL will fail to apply any dtbo
> and fail back to the bootloader menu. There are two changes needed:
> 
> * Add a label named qcom_tzlog
> * Add a label named arch_timer to the timer node

You said that in the commit message.

Regards,
Bjorn

> ---
> Changes in v2:
> - Drop tz log changes
> - Add tz log label to a generic node
> - Link to v1: https://lore.kernel.org/r/20260129-sm8550-abl-dtbo-v1-0-abca3be14024@gmail.com
> ---
>  arch/arm64/boot/dts/qcom/sm8550.dtsi | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> index e3f93f4f412ded9583a6bc9215185a0daf5f1b57..04ea1a4a015aa5a4fd615e068b6f18b7c336607c 100644
> --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> @@ -32,7 +32,8 @@ / {
>  	#address-cells = <2>;
>  	#size-cells = <2>;
>  
> -	chosen { };
> +	// This label is required by ABL to apply a dtbo
> +	qcom_tzlog: chosen { };
>  
>  	clocks {
>  		xo_board: xo-board {
> @@ -6756,7 +6757,8 @@ trip-point2 {
>  		};
>  	};
>  
> -	timer {
> +	// This label is required by ABL to apply a dtbo
> +	arch_timer: timer {
>  		compatible = "arm,armv8-timer";
>  		interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW) 0>,
>  			     <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW) 0>,
> 
> ---
> base-commit: 3f24e4edcd1b8981c6b448ea2680726dedd87279
> change-id: 20260128-sm8550-abl-dtbo-96288634f00d
> 
> Best regards,
> -- 
> Aaron Kling <webgeek1234@...il.com>
> 
>