linux-kernel - [PATCH v2 06/15] irqchip/qcom-mpm: Use mbox_ring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260207200128.v2.6.I59d887fd641f70e40950b7545ed31f193cd1c270@changeid>
Date: Sat,  7 Feb 2026 20:01:28 -0800
From: Douglas Anderson <dianders@...omium.org>
To: jassisinghbrar@...il.com
Cc: Douglas Anderson <dianders@...omium.org>,
	linux-kernel@...r.kernel.org,
	tglx@...nel.org
Subject: [PATCH v2 06/15] irqchip/qcom-mpm: Use mbox_ring_doorbell() instead of NULL message

As per the patch ("mailbox: Deprecate NULL mbox messages; Introduce
mbox_ring_doorbell()"), we want to switch all users of NULL mailbox
messages to use mbox_ring_doorbell().

This client only ever sent NULL messages, so the transition is
straightforward.

This client didn't previously call mbox_client_txdone() and it appears
that the mailboxes it hooks up with (qcom-apcs-ipc-mailbox.c or
qcom-ipcc.c) have both `txdone_irq` and `txdone_poll` as
false. Presumably this means the client was relying the mailbox core's
quirky behavior when sending NULL messages.

Signed-off-by: Douglas Anderson <dianders@...omium.org>
---

(no changes since v1)

 drivers/irqchip/irq-qcom-mpm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-qcom-mpm.c b/drivers/irqchip/irq-qcom-mpm.c
index 83f31ea657b7..5b79d95bf1fb 100644
--- a/drivers/irqchip/irq-qcom-mpm.c
+++ b/drivers/irqchip/irq-qcom-mpm.c
@@ -302,7 +302,7 @@ static int mpm_pd_power_off(struct generic_pm_domain *genpd)
 		qcom_mpm_write(priv, MPM_REG_STATUS, i, 0);

 	/* Notify RPM to write vMPM into HW */
-	ret = mbox_send_message(priv->mbox_chan, NULL);
+	ret = mbox_ring_doorbell(priv->mbox_chan);
 	if (ret < 0)
 		return ret;

-- 
2.53.0.rc2.204.g2597b5adb4-goog