linux-kernel - Re: [PATCH 1/3] staging: media: atomisp: Fix braces on incorrect lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aYoATsI9KB8bgwjz@smile.fi.intel.com>
Date: Mon, 9 Feb 2026 17:42:06 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Matt Wardle <matt@...twardle.net>
Cc: Hans de Goede <hansg@...nel.org>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Andy Shevchenko <andy@...nel.org>,
	Sakari Ailus <sakari.ailus@...ux.intel.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-media@...r.kernel.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] staging: media: atomisp: Fix braces on incorrect
 lines

On Mon, Feb 09, 2026 at 02:29:07PM +0000, Matt Wardle wrote:
> Fix checkpatch.pl errors:
> 
> ERROR: open brace '{' following function definitions go on the next line
> ERROR: that open brace { should be on the previous line

Nice! My comments below.

...

> store_dvs_6axis_config(

>      const struct ia_css_dvs_6axis_config *dvs_6axis_config,
>      const struct ia_css_binary *binary,
>      const struct ia_css_frame_info *dvs_in_frame_info,
> -    ia_css_ptr ddr_addr_y) {
> +    ia_css_ptr ddr_addr_y)
> +{

This makes no sense to touch before the parameters are indented correctly.
I dunno if open parenthesis is fine at the end of the line, but I would do it
differently, as

store_dvs_6axis_config(const struct ia_css_dvs_6axis_config *dvs_6axis_config,
		       const struct ia_css_binary *binary,
		       ...)
{

...

The bottom line is, you need to check manually these and make prerequisite
patch to first fix the indentation.

...

>  int
>  ia_css_get_dvs2_statistics(
>      struct ia_css_dvs2_statistics          *host_stats,
> -    const struct ia_css_isp_dvs_statistics *isp_stats) {
> +    const struct ia_css_isp_dvs_statistics *isp_stats)
> +{

Ditto.

And when you go with indentation it makes sense to combine (it's fine in this
case) those changes with the splitting { to the next line.

-- 
With Best Regards,
Andy Shevchenko