linux-kernel - Re: [PATCH v2 07/15] remoteproc: xlnx: Use mbox_ring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3s7angk25pwtyonscqey2lq6uwxysoypvnbifloydgjao4wh22@7dofvqyj7di2>
Date: Mon, 9 Feb 2026 09:40:42 -0600
From: Bjorn Andersson <andersson@...nel.org>
To: Douglas Anderson <dianders@...omium.org>
Cc: jassisinghbrar@...il.com, linux-kernel@...r.kernel.org, 
	linux-remoteproc@...r.kernel.org, mathieu.poirier@...aro.org
Subject: Re: [PATCH v2 07/15] remoteproc: xlnx: Use mbox_ring_doorbell()
 instead of NULL message

On Sat, Feb 07, 2026 at 08:01:29PM -0800, Douglas Anderson wrote:
> As per the patch ("mailbox: Deprecate NULL mbox messages; Introduce
> mbox_ring_doorbell()"), we want to switch all users of NULL mailbox
> messages to use mbox_ring_doorbell().
> 
> This client only ever sent NULL message on the rx channel, so the
> transition is straightforward.
> 
> Signed-off-by: Douglas Anderson <dianders@...omium.org>

Acked-by: Bjorn Andersson <andersson@...nel.org>

Regards,
Bjorn

> ---
> 
> (no changes since v1)
> 
>  drivers/remoteproc/xlnx_r5_remoteproc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/remoteproc/xlnx_r5_remoteproc.c b/drivers/remoteproc/xlnx_r5_remoteproc.c
> index a7b75235f53e..de807247e9c9 100644
> --- a/drivers/remoteproc/xlnx_r5_remoteproc.c
> +++ b/drivers/remoteproc/xlnx_r5_remoteproc.c
> @@ -245,7 +245,7 @@ static void zynqmp_r5_mb_rx_cb(struct mbox_client *cl, void *msg)
>  	memcpy(buf_msg->data, ipi_msg->data, len);
>  
>  	/* received and processed interrupt ack */
> -	if (mbox_send_message(ipi->rx_chan, NULL) < 0)
> +	if (mbox_ring_doorbell(ipi->rx_chan) < 0)
>  		dev_err(cl->dev, "ack failed to mbox rx_chan\n");
>  
>  	schedule_work(&ipi->mbox_work);
> -- 
> 2.53.0.rc2.204.g2597b5adb4-goog
>