linux-kernel - Re: [PATCH v2 1/2] dt-bindings: Add binding document for cm36686

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47a3badb-7217-49c6-98e1-e01d133edc78@kernel.org>
Date: Mon, 9 Feb 2026 17:12:19 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Erikas Bitovtas <xerikasxx@...il.com>, Jonathan Cameron
 <jic23@...nel.org>, David Lechner <dlechner@...libre.com>,
 Nuno Sá <nuno.sa@...log.com>,
 Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Kevin Tsai <ktsai@...ellamicro.com>
Cc: linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht,
 phone-devel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: Add binding document for cm36686

On 09/02/2026 16:02, Erikas Bitovtas wrote:
>> Compatible says cm36672p... Confusing. 
>> Why higher number is the fallback? Explain this in the commit msg.
> 
> This driver was initially written for cm36686, which is an ambient light and
> proximity sensor. But cm36672p shares the same register and regfield layout, it
> is just missing an ambient light channel, because it is a proximity-only sensor
> and has no ambient light registers.

so cm36672p is the base and cm36686 is superset? Then the binding should
be named as the base. Just like the compatible list.

> In v1 the compatible looked like this:
>   compatible:
>     enum:
>       - capella,cm36686
>       - capella,cm36672p
> 

You just removed entire context except my comment, so what do you refer
to exactly? I have many of such emails per day.

Best regards,
Krzysztof