linux-kernel - Re: [PATCH v2 9/9] arm64: dts: qcom: qcs6490-rb3gen2: Enable EUD debug functionality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e8d9e822-0482-408d-aef7-ebdd3fc87d96@oss.qualcomm.com>
Date: Mon, 9 Feb 2026 09:06:28 -0800
From: Elson Serrao <elson.serrao@....qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
 <conor+dt@...nel.org>,
        Souradeep Chowdhury <quic_schowdhu@...cinc.com>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 9/9] arm64: dts: qcom: qcs6490-rb3gen2: Enable EUD
 debug functionality



On 2/3/2026 5:38 AM, Konrad Dybcio wrote:
> On 1/27/26 12:38 AM, Elson Serrao wrote:
>> On this board, EUD resides on the primary High-Speed USB data path between
>> the connector and the DWC3 controller. Update the device tree connections
>> to correctly map the connector and controller endpoints, and describe
>> role-switch capability on the EUD primary path.
>>
>> Signed-off-by: Elson Serrao <elson.serrao@....qualcomm.com>
>> ---
>>  arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 20 ++++++++++++++++++--
>>  1 file changed, 18 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
>> index f29a352b0288..2fc2d0aed8dd 100644
>> --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
>> @@ -194,7 +194,7 @@ port@0 {
>>  					reg = <0>;
>>  
>>  					pmic_glink_hs_in: endpoint {
>> -						remote-endpoint = <&usb_1_dwc3_hs>;
>> +						remote-endpoint = <&eud_con0>;
>>  					};
>>  				};
>>  
>> @@ -1176,13 +1176,29 @@ &usb_1 {
>>  };
>>  
>>  &usb_1_dwc3_hs {
>> -	remote-endpoint = <&pmic_glink_hs_in>;
>> +	remote-endpoint = <&eud_usb0>;
>>  };
>>  
>>  &usb_1_dwc3_ss {
>>  	remote-endpoint = <&usb_dp_qmpphy_usb_ss_in>;
> 
> The on-SoC links can be deferred to the common DTSI
> 
> 

Thanks Konrad for the detailed review.
I’ll defer the on‑SoC USB controller to EUD node mapping to the common DTSI.

>>  };
>>  
>> +&eud_con0 {
>> +	remote-endpoint = <&pmic_glink_hs_in>;
>> +};
>> +
>> +&eud_usb0 {
>> +	remote-endpoint = <&usb_1_dwc3_hs>;
>> +};
>> +
>> +&eud {
>> +	status = "okay";
> 
> And I think it should be okay to keep it enabled by default
> 
Ack

Thanks
Elson