linux-kernel - Re: [RESEND PATCH v2] scsi: core: Add 'serial' sysfs attribute for SCSI/SATA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <430f606d-9305-41d9-9a49-b9ab6894cd61@acm.org>
Date: Mon, 9 Feb 2026 09:31:39 -0800
From: Bart Van Assche <bvanassche@....org>
To: Igor Pylypiv <ipylypiv@...gle.com>,
 "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
 "Martin K. Petersen" <martin.petersen@...cle.com>
Cc: linux-scsi@...r.kernel.org, linux-ide@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH v2] scsi: core: Add 'serial' sysfs attribute for
 SCSI/SATA

On 2/5/26 10:00 AM, Igor Pylypiv wrote:
> +	return sysfs_emit(buf, "%s\n", buf);

Since many snprintf() variants do not allow to specify the output buffer 
as input argument, the above seems risky to me. Has it been considered 
to replace the above statement with the following?

	return sysfs_emit_at(buf, strlen(buf), "\n");

Thanks,

Bart.