linux-kernel - [PATCH] ACPI: battery: Avoid dereferencing battery before NULL check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260209173827.87744-1-alperyasinak1@gmail.com>
Date: Mon,  9 Feb 2026 20:38:27 +0300
From: Alper Ak <alperyasinak1@...il.com>
To: rafael@...nel.org
Cc: lenb@...nel.org,
	linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Alper Ak <alperyasinak1@...il.com>
Subject: [PATCH] ACPI: battery: Avoid dereferencing battery before NULL check

acpi_battery_notify() dereferences the battery pointer before checking
for NULL. Reorder the check to ensure the pointer is validated before
use.

This issue was reported by the Smatch static analyzer.

Fixes: 08b54fd57782 ("ACPI: battery: Adjust event notification routine")
Signed-off-by: Alper Ak <alperyasinak1@...il.com>
---
 drivers/acpi/battery.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c
index 3bbddd6f622c..abc82be69215 100644
--- a/drivers/acpi/battery.c
+++ b/drivers/acpi/battery.c
@@ -1063,12 +1063,14 @@ static void acpi_battery_refresh(struct acpi_battery *battery)
 static void acpi_battery_notify(acpi_handle handle, u32 event, void *data)
 {
 	struct acpi_battery *battery = data;
-	struct acpi_device *device = battery->device;
+	struct acpi_device *device;
 	struct power_supply *old;
 
 	if (!battery)
 		return;
 
+	device = battery->device;
+
 	guard(mutex)(&battery->update_lock);
 
 	old = battery->bat;
-- 
2.43.0