linux-kernel - Re: [RESEND PATCH v2] scsi: core: Add 'serial' sysfs attribute for SCSI/SATA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9b4de8bc-273c-48c3-9c26-4055b2a5d306@acm.org>
Date: Mon, 9 Feb 2026 12:27:42 -0800
From: Bart Van Assche <bvanassche@....org>
To: Igor Pylypiv <ipylypiv@...gle.com>
Cc: "James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
 "Martin K. Petersen" <martin.petersen@...cle.com>,
 linux-scsi@...r.kernel.org, linux-ide@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH v2] scsi: core: Add 'serial' sysfs attribute for
 SCSI/SATA

On 2/9/26 11:31 AM, Igor Pylypiv wrote:
> Instead, I will put a newline
> manually and return the correct number of characters. PAGE_SIZE is passed
> to scsi_vpd_lun_serial() so we don't sysfs_emit_at() to check it again.
> 
> 	buf[ret] = '\n';
> 	return ret + 1;

This sounds good to me.

Thanks,

Bart.