linux-kernel - Re: [PATCH] ARM: dts: imx6ull-dhcor: Handle both 1DX and 1YN WiFi on i.MX6ULL DHCOR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9760a129-ee03-4556-b98b-2625739b21fa@nabladev.com>
Date: Mon, 9 Feb 2026 21:41:24 +0100
From: Marek Vasut <marex@...ladev.com>
To: Frank Li <Frank.li@....com>
Cc: linux-arm-kernel@...ts.infradead.org,
 Christoph Niedermaier <cniedermaier@...electronics.com>,
 Conor Dooley <conor+dt@...nel.org>, Fabio Estevam <festevam@...il.com>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Rob Herring <robh@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>,
 Shawn Guo <shawnguo@...nel.org>, devicetree@...r.kernel.org,
 imx@...ts.linux.dev, kernel@...electronics.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: imx6ull-dhcor: Handle both 1DX and 1YN WiFi on
 i.MX6ULL DHCOR

On 2/9/26 8:17 PM, Frank Li wrote:

Hello Frank,

>> diff --git a/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-som.dtsi b/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-som.dtsi
>> index 75486e1b0c15f..a0adcd3fe1229 100644
>> --- a/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-som.dtsi
>> +++ b/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-som.dtsi
>> @@ -201,7 +201,7 @@ &uart2 {
>>   	 * the speed can be increased accordingly.
>>   	 */
>>   	bluetooth: bluetooth {
>> -		compatible = "brcm,bcm43430a1-bt"; /* muRata 1DX */
>> +		compatible = "brcm,bcm4329-bt"; /* muRata 1DX or 1YN */
> 
> in driver, brcm,bcm43430a1-bt and brcm,bcm4329-bt should be the same.
> 
>>   		max-speed = <3000000>;
>>   		vbat-supply = <&vcc_3v3>;
>>   		vddio-supply = <&vcc_3v3>;
>> @@ -222,7 +222,7 @@ &usdhc1 {
>>   	status = "okay";
>>
>>   	brcmf: wifi@1 {
>> -		compatible = "brcm,bcm43430a1-fmac", "brcm,bcm4329-fmac"; /* muRata 1DX */
>> +		compatible = "brcm,bcm4329-fmac"; /* muRata 1DX or 1YN */
> 
> driver have not check "brcm,bcm43430a1-fmac".
> 
> Look like driver can work for both CHIP without modify dts.
Sure, the driver can work even with the current DT, but the DT isn't 
accurate as it describes compatible string specifically for the 1DX 
part. This change makes the DT use more generic compatible which fits 
both 1DX and 1YN parts. And it also fixes the comment accordingly.