[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <46449ed46d60767bd13b980e5ab63faf4364f718.camel@ibm.com>
Date: Mon, 9 Feb 2026 20:48:17 +0000
From: Viacheslav Dubeyko <Slava.Dubeyko@....com>
To: "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
"slava@...eyko.com" <slava@...eyko.com>
CC: "linux-mm@...ck.org" <linux-mm@...ck.org>,
"linux-fsdevel@...r.kernel.org"
<linux-fsdevel@...r.kernel.org>,
"linux-kernel@...r.kernel.org"
<linux-kernel@...r.kernel.org>,
"bpf@...r.kernel.org" <bpf@...r.kernel.org>
Subject: RE: [RFC PATCH v1 1/4] ml-lib: Introduce Machine Learning (ML)
library declarations
On Sat, 2026-02-07 at 16:52 +0100, Greg KH wrote:
> On Fri, Feb 06, 2026 at 11:11:33AM -0800, Viacheslav Dubeyko wrote:
> > + * @kobj: /sys/<subsystem>/<ml_model>/ ML model object
> > + * @kobj_unregister: completion state for <ml_model> kernel object
> > + */
> > +struct ml_lib_model {
> > + atomic_t mode;
> > + atomic_t state;
> > + const char *subsystem_name;
> > + const char *model_name;
> > +
> > + struct ml_lib_subsystem *parent;
> > +
> > + spinlock_t parent_state_lock;
> > + struct ml_lib_subsystem_state * __rcu parent_state;
> > +
> > + spinlock_t options_lock;
> > + struct ml_lib_model_options * __rcu options;
> > +
> > + spinlock_t dataset_lock;
> > + struct ml_lib_dataset * __rcu dataset;
> > +
> > + struct ml_lib_model_operations *model_ops;
> > + struct ml_lib_subsystem_state_operations *system_state_ops;
> > + struct ml_lib_dataset_operations *dataset_ops;
> > + struct ml_lib_request_config_operations *request_config_ops;
> > +
> > + /* /sys/<subsystem>/<ml_model>/ */
> > + struct kobject kobj;
> > + struct completion kobj_unregister;
> > +};
>
> Do NOT abuse sysfs for something like this. Please make your own
> filesystem or char device or something else, but this is not what sysfs
> is for at all, sorry.
>
Currently, sysfs entry is used for sending commands (start, stop,
prepare_dataset, discard_dataset) from user-space on the kernel-space side. And
the intention of using sysfs entries is the export information about kernel
subsystem and exchanging by commands and notifications between user-space and
kernel-space sides. Do you mean that it is wrong using of sysfs? Have I
misunderstood your point?
Thanks,
Slava.
Powered by blists - more mailing lists