linux-kernel - Re: [PATCH] arm64: dts: mediatek: mt8189: Add pinmux macro header file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1b092f9c-d0b1-47df-a83e-a99d7491a32b@lechnology.com>
Date: Mon, 9 Feb 2026 15:48:45 -0600
From: David Lechner <david@...hnology.com>
To: Cathy Xu <ot_cathy.xu@...iatek.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
 Yong Mao <yong.mao@...iatek.com>, Wenbin Mei <Wenbin.Mei@...iatek.com>,
 Axe Yang <Axe.Yang@...iatek.com>, Lei Xue <Lei.Xue@...iatek.com>
Subject: Re: [PATCH] arm64: dts: mediatek: mt8189: Add pinmux macro header
 file

On 9/18/25 9:03 PM, Cathy Xu wrote:
> Add the pinctrl header file on MediaTek mt8189.
> 
> Signed-off-by: Cathy Xu <ot_cathy.xu@...iatek.com>
> ---
> This patch is base on the patch series:
> https://patchwork.kernel.org/project/linux-mediatek/list/?series=981475
> [1] dt-bindings: pinctrl: mediatek: Add support for mt8189
> [2] arm64: dts: mediatek: mt8189: Add pinmux macro header file
> [3] pinctrl: mediatek: Add pinctrl driver on mt8189
> Since patch [1] and [3] of the series have already been merged, this
> patch(patch [2]) is being resent individually after modifications.
> ---
>  arch/arm64/boot/dts/mediatek/mt8189-pinfunc.h | 1125 +++++++++++++++++
>  1 file changed, 1125 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/mediatek/mt8189-pinfunc.h
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8189-pinfunc.h b/arch/arm64/boot/dts/mediatek/mt8189-pinfunc.h
> new file mode 100644
> index 000000000000..df69f50c267a
> --- /dev/null
> +++ b/arch/arm64/boot/dts/mediatek/mt8189-pinfunc.h

General question:

Why do we have similar files in two different places different places?

$ ls arch/arm64/boot/dts/mediatek/*-pin*
arch/arm64/boot/dts/mediatek/mt2712-pinfunc.h
arch/arm64/boot/dts/mediatek/mt6878-pinfunc.h
arch/arm64/boot/dts/mediatek/mt6893-pinfunc.h
arch/arm64/boot/dts/mediatek/mt8167-pinfunc.h
arch/arm64/boot/dts/mediatek/mt8173-pinfunc.h
arch/arm64/boot/dts/mediatek/mt8196-pinfunc.h
arch/arm64/boot/dts/mediatek/mt8516-pinfunc.h

$ ls include/dt-bindings/pinctrl/mt*
include/dt-bindings/pinctrl/mt65xx.h
include/dt-bindings/pinctrl/mt6779-pinfunc.h
include/dt-bindings/pinctrl/mt6795-pinfunc.h
include/dt-bindings/pinctrl/mt6797-pinfunc.h
include/dt-bindings/pinctrl/mt7623-pinfunc.h
include/dt-bindings/pinctrl/mt8135-pinfunc.h
include/dt-bindings/pinctrl/mt8183-pinfunc.h
include/dt-bindings/pinctrl/mt8186-pinfunc.h
include/dt-bindings/pinctrl/mt8192-pinfunc.h
include/dt-bindings/pinctrl/mt8195-pinfunc.h
include/dt-bindings/pinctrl/mt8365-pinfunc.h


Plus one different naming pattern.

$ ls include/dt-bindings/pinctrl/mediatek,*
include/dt-bindings/pinctrl/mediatek,mt8188-pinfunc.h



Which one is preferred?