linux-kernel - Re: [PATCH] staging: rtl8723bs: improve comment placement and readability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DGASI1BELRMN.OCCUPYE9KJBE@gmail.com>
Date: Mon, 09 Feb 2026 16:38:09 -0600
From: "Ethan Tidmore" <ethantidmore06@...il.com>
To: "Matthew Marsico" <mattmarsico1@...il.com>, <gregkh@...uxfoundation.org>
Cc: <linux-staging@...ts.linux.dev>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: rtl8723bs: improve comment placement and
 readability

On Sun Feb 8, 2026 at 4:56 PM CST, Matthew Marsico wrote:
> Move trailing comments onto their own line, preceding
> the referenced code, and rework them to improve
> readability. No functional change.
>
> Signed-off-by: Matthew Marsico <mattmarsico1@...il.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
> index 587a87fbffeb..fa3b4be11ab2 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
> @@ -174,7 +174,9 @@ u8 rtw_set_802_11_ssid(struct adapter *padapter, struct ndis_802_11_ssid *ssid)
>  						set_fwstate(pmlmepriv, WIFI_ADHOC_STATE);
>  					}
>  				} else {
> -					goto release_mlme_lock;/* it means driver is in WIFI_ADHOC_MASTER_STATE, we needn't create bss again. */
> +					/* Driver is already in WIFI_ADHOC_MASTER_STATE, */
> +					/* do not create BSS again. */

The linux kernel coding style wants multiple line comments to look like
this:

/*
 * Driver is already in WIFI_ADHOC_MASTER_STATE,
 * do not create BSS again.
 */

 Please consult Documentation/process/coding-style.rst under Commenting
 to get more examples.

> +					goto release_mlme_lock;
>  				}
>  			} else {
>  				rtw_lps_ctrl_wk_cmd(padapter, LPS_CTRL_JOINBSS, 1);
> @@ -310,7 +312,9 @@ u8 rtw_set_802_11_infrastructure_mode(struct adapter *padapter,
>  
>  		if ((*pold_state == Ndis802_11Infrastructure) || (*pold_state == Ndis802_11IBSS)) {
>  			if (check_fwstate(pmlmepriv, _FW_LINKED) == true)
> -				rtw_indicate_disconnect(padapter); /* will clr Linked_state; before this function, we must have checked whether issue dis-assoc_cmd or not */
> +				/* Will clear Linked_state */
> +				/* Disassociation has already been handled above */
> +				rtw_indicate_disconnect(padapter);
>  		}
>  
>  		*pold_state = networktype;

Thanks,

ET