linux-kernel - Re: [PATCH RFC v2 08/17] RISC-V: QoS: add resctrl interface for CBQRI controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <202602090729.6197TrBX088760@mse-fl2.zte.com.cn>
Date: Mon,  9 Feb 2026 15:20:00 +0800
From: Gong Shuai <gong.shuai@...echips.com.cn>
To: fustini@...nel.org
Cc: gong.shuai@...echips.com.cn, Dave.Martin@....com,
        acpica-devel@...ts.linux.dev, alex@...ti.fr, aou@...s.berkeley.edu,
        aricciardi@...libre.com, atish.patra@...ux.dev, atishp@...osinc.com,
        babu.moger@....com, ben.horgan@....com, conor+dt@...nel.org,
        cp0613@...ux.alibaba.com, cuiyunhui@...edance.com,
        devicetree@...r.kernel.org, fenghua.yu@...el.com,
        guo.wenjia23@....com.cn, james.morse@....com, krzk+dt@...nel.org,
        lenb@...nel.org, linux-acpi@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
        liu.qingtao2@....com.cn, liwei1518@...il.com, mindal@...ihalf.com,
        npitre@...libre.com, palmer@...belt.com, paul.walmsley@...ive.com,
        peternewman@...gle.com, pjw@...nel.org, rafael@...nel.org,
        reinette.chatre@...el.com, rkrcmar@...tanamicro.com,
        robert.moore@...el.com, robh@...nel.org, samuel.holland@...ive.com,
        sunilvl@...tanamicro.com, tony.luck@...el.com, vasu@...osinc.com,
        ved@...osinc.com, x86@...nel.org, zhiwei_liu@...ux.alibaba.com
Subject: Re: [PATCH RFC v2 08/17] RISC-V: QoS: add resctrl interface for CBQRI controllers

Hi, Drew

> Add interface for CBQRI controller drivers to make use of the resctrl
> filesystem.
> 
> Co-developed-by: Adrien Ricciardi <aricciardi@...libre.com>
> Signed-off-by: Adrien Ricciardi <aricciardi@...libre.com>
> Signed-off-by: Drew Fustini <fustini@...nel.org>
> ---
>
> ...
>
> +u32 resctrl_arch_get_config(struct rdt_resource *r, struct rdt_ctrl_domain *d,
> +			    u32 closid, enum resctrl_conf_type type)
> +{
> +	struct cbqri_resctrl_dom *hw_dom;
> +	struct cbqri_controller *ctrl;
> +	int reg_offset;
> +	u32 percent;
> +	u32 rbwb;
> +	u64 reg;
> +	int err;
> +
> +	hw_dom = container_of(d, struct cbqri_resctrl_dom, resctrl_ctrl_dom);
> +
> +	ctrl = hw_dom->hw_ctrl;
> +
> +	if (!r->alloc_capable)
> +		return resctrl_get_default_ctrl(r);
> +
> +	switch (r->rid) {
> +	case RDT_RESOURCE_L2:
> +	case RDT_RESOURCE_L3:
> +		/* Clear cc_block_mask before read limit operation */
> +		cbqri_set_cbm(ctrl, 0);
> +
> +		/* Capacity read limit operation for RCID (closid) */
> +		err = cbqri_cc_alloc_op(ctrl, CBQRI_CC_ALLOC_CTL_OP_READ_LIMIT, type, closid);

It looks like the parameter order might be incorrect. I believe it should be:
cbqri_cc_alloc_op(ctrl, CBQRI_CC_ALLOC_CTL_OP_READ_LIMIT, closid, type)

Could you please double-check?

> +		if (err < 0) {
> +			pr_err("%s(): operation failed: err = %d", __func__, err);
> +			return resctrl_get_default_ctrl(r);
> +		}
> ...

Thanks,
Shuai
Hi,&nbsp;Drew<br /><br />&gt;&nbsp;Add&nbsp;interface&nbsp;for&nbsp;CBQRI&nbsp;controller&nbsp;drivers&nbsp;to&nbsp;make&nbsp;use&nbsp;of&nbsp;the&nbsp;resctrl<br />&gt;&nbsp;filesystem.<br />&gt;&nbsp;<br />&gt;&nbsp;Co-developed-by:&nbsp;Adrien&nbsp;Ricciardi&nbsp;&lt;aricciardi@...libre.com&gt;<br />&gt;&nbsp;Signed-off-by:&nbsp;Adrien&nbsp;Ricciardi&nbsp;&lt;aricciardi@...libre.com&gt;<br />&gt;&nbsp;Signed-off-by:&nbsp;Drew&nbsp;Fustini&nbsp;&lt;fustini@...nel.org&gt;<br />&gt;&nbsp;---<br />&gt;<br />&gt;&nbsp;...<br />&gt;<br />&gt;&nbsp;+u32&nbsp;resctrl_arch_get_config(struct&nbsp;rdt_resource&nbsp;*r,&nbsp;struct&nbsp;rdt_ctrl_domain&nbsp;*d,<br />&gt;&nbsp;+&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;u32&nbsp;closid,&nbsp;enum&nbsp;resctrl_conf_type&nbsp;type)<br />&gt;&nbsp;+{<br />&gt;&nbsp;+&nbsp;&nbsp;&nbsp;&nbsp;struct&nbsp;cbqri_resctrl_dom&nbsp;*hw_dom;<br />&gt;&nbsp;+&nbsp;&nbsp;&nbsp;&nbsp;struct&nbsp;cbqri_controller&nbsp;*ctrl;<br />&gt;&nbsp;+&nbsp;&nbsp;&nbsp;&nbsp;int&nbsp;reg_offset;<br />&gt;&nbsp;+&nbsp;&nbsp;&nbsp;&nbsp;u32&nbsp;percent;<br />&gt;&nbsp;+&nbsp;&nbsp;&nbsp;&nbsp;u32&nbsp;rbwb;<br />&gt;&nbsp;+&nbsp;&nbsp;&nbsp;&nbsp;u64&nbsp;reg;<br />&gt;&nbsp;+&nbsp;&nbsp;&nbsp;&nbsp;int&nbsp;err;<br />&gt;&nbsp;+<br />&gt;&nbsp;+&nbsp;&nbsp;&nbsp;&nbsp;hw_dom&nbsp;=&nbsp;container_of(d,&nbsp;struct&nbsp;cbqri_resctrl_dom,&nbsp;resctrl_ctrl_dom);<br />&gt;&nbsp;+<br />&gt;&nbsp;+&nbsp;&nbsp;&nbsp;&nbsp;ctrl&nbsp;=&nbsp;hw_dom-&gt;hw_ctrl;<br />&gt;&nbsp;+<br />&gt;&nbsp;+&nbsp;&nbsp;&nbsp;&nbsp;if&nbsp;(!r-&gt;alloc_capable)<br />&gt;&nbsp;+&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;return&nbsp;resctrl_get_default_ctrl(r);<br />&gt;&nbsp;+<br />&gt;&nbsp;+&nbsp;&nbsp;&nbsp;&nbsp;switch&nbsp;(r-&gt;rid)&nbsp;{<br />&gt;&nbsp;+&nbsp;&nbsp;&nbsp;&nbsp;case&nbsp;RDT_RESOURCE_L2:<br />&gt;&nbsp;+&nbsp;&nbsp;&nbsp;&nbsp;case&nbsp;RDT_RESOURCE_L3:<br />&gt;&nbsp;+&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;/*&nbsp;Clear&nbsp;cc_block_mask&nbsp;before&nbsp;read&nbsp;limit&nbsp;operation&nbsp;*/<br />&gt;&nbsp;+&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;cbqri_set_cbm(ctrl,&nbsp;0);<br />&gt;&nbsp;+<br />&gt;&nbsp;+&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;/*&nbsp;Capacity&nbsp;read&nbsp;limit&nbsp;operation&nbsp;for&nbsp;RCID&nbsp;(closid)&nbsp;*/<br />&gt;&nbsp;+&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;err&nbsp;=&nbsp;cbqri_cc_alloc_op(ctrl,&nbsp;CBQRI_CC_ALLOC_CTL_OP_READ_LIMIT,&nbsp;type,&nbsp;closid);<br /><br />It&nbsp;looks&nbsp;like&nbsp;the&nbsp;parameter&nbsp;order&nbsp;might&nbsp;be&nbsp;incorrect.&nbsp;I&nbsp;believe&nbsp;it&nbsp;should&nbsp;be:<br />cbqri_cc_alloc_op(ctrl,&nbsp;CBQRI_CC_ALLOC_CTL_OP_READ_LIMIT,&nbsp;closid,&nbsp;type)<br /><br />Could&nbsp;you&nbsp;please&nbsp;double-check?<br /><br />&gt;&nbsp;+&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;if&nbsp;(err&nbsp;&lt;&nbsp;0)&nbsp;{<br />&gt;&nbsp;+&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;pr_err(&quot;%s():&nbsp;operation&nbsp;failed:&nbsp;err&nbsp;=&nbsp;%d&quot;,&nbsp;__func__,&nbsp;err);<br />&gt;&nbsp;+&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;return&nbsp;resctrl_get_default_ctrl(r);<br />&gt;&nbsp;+&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;}<br />&gt;&nbsp;...<br /><br />Thanks,<br />Shuai