linux-kernel - Re: [PATCH 01/11] dt-bindings: crypto: qcom,ice: Require power-domain and iface clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ffafb3b7-bb9a-48e8-9810-7fd837d52001@kernel.org>
Date: Mon, 9 Feb 2026 08:44:21 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Harshal Dev <harshal.dev@....qualcomm.com>,
 Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
 Herbert Xu <herbert@...dor.apana.org.au>,
 "David S. Miller" <davem@...emloft.net>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>,
 Abel Vesa <abel.vesa@....qualcomm.com>, cros-qcom-dts-watchers@...omium.org
Cc: Brian Masney <bmasney@...hat.com>,
 Neeraj Soni <neeraj.soni@....qualcomm.com>,
 Gaurav Kashyap <gaurav.kashyap@....qualcomm.com>,
 linux-arm-msm@...r.kernel.org, linux-crypto@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/11] dt-bindings: crypto: qcom,ice: Require power-domain
 and iface clk

On 09/02/2026 06:43, Harshal Dev wrote:
>>>> Either I do not understand the point or you still insist on breaking a
>>>> working DTS on kernels with clk_ignore_unused, just because what
>>>> exactly? You claim it did not work, but in fact it did work. So you
>>>> claim it worked by luck, right? And what this patchset achieves? It
>>>> breaks this "work by luck" into "100% not working and broken". I do not
>>>> see how is this an improvement.
>>>>
>>>
>>> My point is something more fundamental. It worked before and it will still continue
>>> to work if:
>>> 1. We pass the 'clk_ignore_unused' flag. or,
>>> 2. If the Linux distro is overriding CONFIG_SCSI_UFS_QCOM to 'y'.
>>
>> I do not agree with this. I already commented about your driver. If you
>> do not believe me, apply your driver patch and show the test results of
>> existing working device.
>>
>>
> 
> Apologies, it seems like I failed to explain correctly what I meant.
> Here I was talking about the existing in-tree ICE driver and not about this particular DT
> binding commit. This commit, as you rightly said and I mentioned below too, breaks backward
> compatibility for existing in-tree and out-of-tree DTS.

I was also talking about existing in-tree ICE driver, not about my
commit. I do not believe anything will work fine with existing in-tree
ICE driver.

We shifted away from this binding in the discussion, imagine it does not
matter. Just look at your driver code.

Best regards,
Krzysztof