linux-kernel - Re: [PATCH v3 20/30] gpu: nova-core: Hopper/Blackwell: add FSP message structures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dda626b9-d2c4-4432-a669-4ae3c4c8b5ec@nvidia.com>
Date: Sun, 8 Feb 2026 17:59:58 -0800
From: John Hubbard <jhubbard@...dia.com>
To: Timur Tabi <ttabi@...dia.com>, Alexandre Courbot <acourbot@...dia.com>,
 "dakr@...nel.org" <dakr@...nel.org>
Cc: "aliceryhl@...gle.com" <aliceryhl@...gle.com>,
 "lossin@...nel.org" <lossin@...nel.org>,
 "a.hindborg@...nel.org" <a.hindborg@...nel.org>,
 "boqun.feng@...il.com" <boqun.feng@...il.com>, Zhi Wang <zhiw@...dia.com>,
 "simona@...ll.ch" <simona@...ll.ch>,
 "alex.gaynor@...il.com" <alex.gaynor@...il.com>,
 "ojeda@...nel.org" <ojeda@...nel.org>, "tmgross@...ch.edu"
 <tmgross@...ch.edu>,
 "nouveau@...ts.freedesktop.org" <nouveau@...ts.freedesktop.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "rust-for-linux@...r.kernel.org" <rust-for-linux@...r.kernel.org>,
 "bjorn3_gh@...tonmail.com" <bjorn3_gh@...tonmail.com>,
 Eliot Courtney <ecourtney@...dia.com>, "airlied@...il.com"
 <airlied@...il.com>, Joel Fernandes <joelagnelf@...dia.com>,
 "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
 "gary@...yguo.net" <gary@...yguo.net>, Alistair Popple <apopple@...dia.com>
Subject: Re: [PATCH v3 20/30] gpu: nova-core: Hopper/Blackwell: add FSP
 message structures

On 2/6/26 11:41 AM, Timur Tabi wrote:
> On Thu, 2026-02-05 at 20:21 -0800, John Hubbard wrote:
>> +pub(crate) struct FmcSignatures {
>> +    hash384: [u32; 12],    // SHA-384 hash (48 bytes)
>> +    public_key: [u32; 96], // RSA public key (384 bytes)
>> +    signature: [u32; 96],  // RSA signature (384 bytes)
>> +}
> 
> You're not treating this fields as arrays of 32-bit integers (and semantically, I don't think they
> are defined that way anyway), so why define them as such?  If you change them to [u8; then you might

This is fallout from my going back and forth many times between
formats, during test-and-fix bringup.

> not need .as_bytes_mut() in the next patch.  This also avoids any endian weirdness that can occur.
> Plus, you'll be able to do this:
> 
> 	hash384: [u8; FSP_HASH_SIZE]

OK, I'll do that.

thanks,
-- 
John Hubbard