linux-kernel - Re: [PATCH drm-misc-next] drm: verisilicon: suppress snprintf warning for pixel clock name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a27e57f1-d170-404d-8023-02d4b0690f88@suse.de>
Date: Mon, 9 Feb 2026 09:35:25 +0100
From: Thomas Zimmermann <tzimmermann@...e.de>
To: Icenowy Zheng <zhengxingda@...as.ac.cn>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 kernel test robot <lkp@...el.com>
Subject: Re: [PATCH drm-misc-next] drm: verisilicon: suppress snprintf warning
 for pixel clock name



Am 07.02.26 um 02:32 schrieb Icenowy Zheng:
> Although it's generally expected that the pixel clock ID will only have
> one decimal digit, this isn't enforced in vs_dc.c source code, and the
> compiler will argue about the buffer being not long enough.
>
> Enlarge the snprintf() buffer for generating pixel clock name to be
> enough for a UINT_MAX pixel clock ID in order to suppress the compiler
> warning.
>
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202602060154.ONBYvM9m-lkp@intel.com/
> Signed-off-by: Icenowy Zheng <zhengxingda@...as.ac.cn>

Reviewed-by: Thomas Zimmermann <tzimmermann@...e.de>

> ---
>   drivers/gpu/drm/verisilicon/vs_dc.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/verisilicon/vs_dc.c b/drivers/gpu/drm/verisilicon/vs_dc.c
> index ba1b3f261a3ae..5f629d2d4beac 100644
> --- a/drivers/gpu/drm/verisilicon/vs_dc.c
> +++ b/drivers/gpu/drm/verisilicon/vs_dc.c
> @@ -46,8 +46,8 @@ static int vs_dc_probe(struct platform_device *pdev)
>   	struct vs_dc *dc;
>   	void __iomem *regs;
>   	unsigned int port_count, i;
> -	/* pix0/pix1 */
> -	char pixclk_name[5];
> +	/* pix%u */
> +	char pixclk_name[14];
>   	int irq, ret;
>   
>   	if (!dev->of_node) {

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)