linux-kernel - Re: [PATCH v4 0/4] firmware: ti_sci: Introduce BOARDCFG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260209095159.pfcthh5a4yo4q2em@lcpd911>
Date: Mon, 9 Feb 2026 15:21:59 +0530
From: Dhruva Gole <d-gole@...com>
To: "Thomas Richard (TI)" <thomas.richard@...tlin.com>
CC: Nishanth Menon <nm@...com>, Tero Kristo <kristo@...nel.org>, "Santosh
 Shilimkar" <ssantosh@...nel.org>, Michael Turquette
	<mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, Gregory CLEMENT
	<gregory.clement@...tlin.com>, <richard.genoud@...tlin.com>, Udit Kumar
	<u-kumar1@...com>, Prasanth Mantena <p-mantena@...com>, Abhash Kumar
	<a-kumar2@...com>, Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
	<linux-clk@...r.kernel.org>
Subject: Re: [PATCH v4 0/4] firmware: ti_sci: Introduce BOARDCFG_MANAGED mode
 for Jacinto family

On Feb 04, 2026 at 16:03:37 +0100, Thomas Richard (TI) wrote:
> The fourth iteration of this series adds support for two new firmware
> capabilities:
> - MSG_FLAG_CAPS_LPM_IRQ_CONTEXT_LOST: Indicates that DM-Firmware is not
>   able to restore IRQ context during resume after suspend-to-ram.
> - MSG_FLAG_CAPS_LPM_CLK_CONTEXT_LOST: Indicates that DM-Firmware is not
>   able to restore clock context (rate and parent configuration) during
>   resume after suspend-to-ram.
> 
> Now, ti_sci driver determines whether to restore IRQs based on the
> MSG_FLAG_CAPS_LPM_IRQ_CONTEXT_LOST capability rather than the
> BOARDCFG_MANAGED mode. The same logic applies to the clock context.
> 
> Both J784s4 and J7200 platforms support these new capabilities. A
> corresponding pull request has been submitted on DM-Firmware side to
> define and enable these capabilities.
> 
> The value for the BOARDCFG_MANAGED mode has also been fixed.
> 
> Public documentation for BOARDCFG_MANAGED mode and these new capabilities
> is currently unavailable. I will update the series with relevant
> documentation references as soon as they become available.
> 
> I rebased the series on linux-next next-20260202.
> 
> Best Regards,
> Thomas
> 
> Signed-off-by: Thomas Richard (TI) <thomas.richard@...tlin.com>
> ---
> Changes in v4:
> - rebase on linux-next next-20260202.
> - fix BOARDCFG_MANAGED value.
> - add MSG_FLAG_CAPS_LPM_IRQ_CONTEXT_LOST firmware capability.
> - add MSG_FLAG_CAPS_LPM_CLK_CONTEXT_LOST firmware capability.
> - Link to v3: https://lore.kernel.org/r/20251205-ti-sci-jacinto-s2r-restore-irq-v3-0-d06963974ad4@bootlin.com
> 
> Changes in v3:
> - rebased on linux-next
> - sci-clk: context_restore() operation restores also rate.
> - Link to v2: https://lore.kernel.org/r/20251127-ti-sci-jacinto-s2r-restore-irq-v2-0-a487fa3ff221@bootlin.com
> 
> Changes in v2:
> - ti_sci: use hlist to store IRQs.
> - sci-clk: add context_restore operation
> - ti_sci: restore clock parents during resume
> - Link to v1: https://lore.kernel.org/r/20251017-ti-sci-jacinto-s2r-restore-irq-v1-0-34d4339d247a@bootlin.com
> 
> ---
> Thomas Richard (TI) (4):
>       firmware: ti_sci: add BOARDCFG_MANAGED mode support
>       firmware: ti_sci: add support for restoring IRQs during resume
>       clk: keystone: sci-clk: add restore_context() operation
>       firmware: ti_sci: add support for restoring clock context during resume

The series looks good to me, just checking if maintainer prefers the 2/4
PATCH on IRQ restore to be split up. IMO similar to how you've split up
the clk restore support and then actually restored clk context in
another patch, you can do similar split up for IRQ.
No strong opinions from my side though.

Reviewed-by: Dhruva Gole <d-gole@...com>

> 
>  drivers/clk/keystone/sci-clk.c |  42 +++++++++--
>  drivers/firmware/ti_sci.c      | 164 ++++++++++++++++++++++++++++++++++++++---
>  drivers/firmware/ti_sci.h      |   6 ++
>  3 files changed, 192 insertions(+), 20 deletions(-)
> ---
> base-commit: c6fb8985458d675f32a22788f30afcba754b6d78
> change-id: 20251010-ti-sci-jacinto-s2r-restore-irq-428e008fd10c
> 
> Best regards,
> -- 
> Thomas Richard (TI) <thomas.richard@...tlin.com>
> 
> 

-- 
Best regards,
Dhruva Gole
Texas Instruments Incorporated