linux-kernel - Re: [RFC PATCH v2 09/12] spi: cadence-quadspi: add PHY tuning infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DGAC4N62UZQQ.3R7TLX87PECU3@kernel.org>
Date: Mon, 09 Feb 2026 10:48:21 +0100
From: "Michael Walle" <mwalle@...nel.org>
To: "Santhosh Kumar K" <s-k6@...com>, <broonie@...nel.org>,
 <robh@...nel.org>, <krzk+dt@...nel.org>, <conor+dt@...nel.org>,
 <miquel.raynal@...tlin.com>, <richard@....at>, <vigneshr@...com>,
 <tudor.ambarus@...aro.org>, <pratyush@...nel.org>
Cc: <linux-spi@...r.kernel.org>, <devicetree@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, <linux-mtd@...ts.infradead.org>,
 <praneeth@...com>, <u-kumar1@...com>, <p-mantena@...com>, <a-dutta@...com>
Subject: Re: [RFC PATCH v2 09/12] spi: cadence-quadspi: add PHY tuning
 infrastructure

On Tue Jan 13, 2026 at 3:16 PM CET, Santhosh Kumar K wrote:
> +static int cqspi_get_phy_pattern_offset(struct device *dev, u32 *offset)

..

> +	partition_np = of_get_child_by_name(flash_np, "partitions");
> +	if (!partition_np) {
> +		of_node_put(flash_np);
> +		return -ENODEV;
> +	}
> +
> +	for_each_child_of_node(partition_np, part_np) {
> +		if (of_property_read_string(part_np, "label", &label) ||
> +		    !strstr(label, "phypattern"))
> +			continue;

There was already a review comment on the last version. Moving this
into the driver doesn't make it any better. In fact this might
create a (bad) precedent for future drivers.

-michael

Download attachment "signature.asc" of type "application/pgp-signature" (298 bytes)