[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <317e9030-849a-4a54-a4e6-75fc93b78935@gmail.com>
Date: Mon, 9 Feb 2026 16:56:18 +0530
From: tessolveupstream@...il.com
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>, andersson@...nel.org,
konradybcio@...nel.org
Cc: robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org,
Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
Subject: Re: [PATCH v12 3/3] arm64: dts: qcom: talos-evk: Add support for
QCS615 talos evk board
On 28-01-2026 17:29, Konrad Dybcio wrote:
> On 1/14/26 11:00 AM, Sudarshan Shetty wrote:
>> Add the device tree for the QCS615-based Talos EVK platform. The
>> platform is composed of a System-on-Module following the SMARC
>> standard, and a Carrier Board.
>>
>> The Carrier Board supports several display configurations, HDMI and
>> LVDS. Both configurations use the same base hardware, with the display
>> selection controlled by a DIP switch.
>>
>> Use a DTBO file, talos-evk-lvds-auo,g133han01.dtso, which defines an
>> overlay that disables HDMI and adds LVDS. The DTs file talos-evk
>> can describe the HDMI display configurations.
>>
>> The initial device tree includes support for:
>> - CPU and memory
>> - UART
>> - GPIOs
>> - Regulators
>> - PMIC
>> - Early console
>> - AT24MAC602 EEPROM
>> - MCP2515 SPI to CAN
>> - ADV7535 DSI-to-HDMI bridge
>> - DisplayPort interface
>> - SN65DSI84ZXHR DSI-to-LVDS bridge
>> - Wi-Fi/BT
>>
>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
>> Signed-off-by: Sudarshan Shetty <tessolveupstream@...il.com>
>> ---
>
> [...]
>
>> + wifi_reg_en_pins_state: wifi-reg-en-pins-state {
>> + pins = "gpio91";
>> + function = "gpio";
>> + drive-strength = <8>;
>> + output-high;
>> + bias-pull-up;
>> + };
>> +
>> + wlan_en_state: wlan-en-state {
>> + pins = "gpio84";
>> + function = "gpio";
>> + drive-strength = <16>;
>> + bias-pull-down;
>> + output-low;
>> + };
>
> The output-low/high properties should be unnecessary since the
> drivers that requests the connected GPIOs control their state
>
> otherwise, I think it's time to finally close in on this..
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
>
Sure, will take care in the next patch.
Thank you.
> Konrad
Powered by blists - more mailing lists