linux-kernel - Re: [PATCH v8 2/3] reset: add Sky1 soc reset support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <656acb84-ed6d-4251-8f0d-ef5602d3bf19@kernel.org>
Date: Mon, 9 Feb 2026 12:35:26 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Gary Yang <gary.yang@...tech.com>, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, p.zabel@...gutronix.de, peter.chen@...tech.com,
 unicorn_wang@...look.com, inochiama@...il.com, alchark@...il.com
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, cix-kernel-upstream@...tech.com
Subject: Re: [PATCH v8 2/3] reset: add Sky1 soc reset support

On 09/02/2026 10:33, Gary Yang wrote:
> +static int sky1_system_control_probe(struct platform_device *pdev)
> +{
> +	struct device *dev = &pdev->dev;
> +	const struct mfd_cell *cell =
> +			(struct mfd_cell *)of_device_get_match_data(dev);
> +
> +	return mfd_add_devices(dev, PLATFORM_DEVID_NONE, cell, 1, NULL, 0, NULL);
> +}
> +
> +static const struct of_device_id sky1_system_control_of_match[] = {
> +	{ .compatible = "cix,sky1-system-control",
> +	  .data = sky1_system_control_devs},
> +	{ .compatible = "cix,sky1-s5-system-control",
> +	  .data = sky1_s5_system_control_devs},
> +	{},
> +};
> +MODULE_DEVICE_TABLE(of, sky1_system_control_of_match);
> +
> +static struct platform_driver sky1_system_control_driver = {
> +	.driver = {
> +		.name = "sky1-system-control",
> +		.of_match_table = sky1_system_control_of_match,
> +	},
> +	.probe = sky1_system_control_probe,

I do not understand why do you need thish driver in the first place.
It's completely empty - just spawns reset driver, so you only need a
reset driver.

Layers of indirection are never helpful.

Best regards,
Krzysztof