linux-kernel - Re: [PATCH v3 30/30] gpu: nova-core: clarify the GPU firmware boot steps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <81280b58-965f-475b-9d46-d03347617d64@nvidia.com>
Date: Sun, 8 Feb 2026 18:22:40 -0800
From: John Hubbard <jhubbard@...dia.com>
To: Timur Tabi <ttabi@...dia.com>, Alexandre Courbot <acourbot@...dia.com>,
 "dakr@...nel.org" <dakr@...nel.org>
Cc: "aliceryhl@...gle.com" <aliceryhl@...gle.com>,
 "lossin@...nel.org" <lossin@...nel.org>,
 "a.hindborg@...nel.org" <a.hindborg@...nel.org>,
 "boqun.feng@...il.com" <boqun.feng@...il.com>, Zhi Wang <zhiw@...dia.com>,
 "simona@...ll.ch" <simona@...ll.ch>,
 "alex.gaynor@...il.com" <alex.gaynor@...il.com>,
 "ojeda@...nel.org" <ojeda@...nel.org>, "tmgross@...ch.edu"
 <tmgross@...ch.edu>,
 "nouveau@...ts.freedesktop.org" <nouveau@...ts.freedesktop.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "rust-for-linux@...r.kernel.org" <rust-for-linux@...r.kernel.org>,
 "bjorn3_gh@...tonmail.com" <bjorn3_gh@...tonmail.com>,
 Eliot Courtney <ecourtney@...dia.com>, "airlied@...il.com"
 <airlied@...il.com>, Joel Fernandes <joelagnelf@...dia.com>,
 "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
 "gary@...yguo.net" <gary@...yguo.net>, Alistair Popple <apopple@...dia.com>
Subject: Re: [PATCH v3 30/30] gpu: nova-core: clarify the GPU firmware boot
 steps

On 2/8/26 6:14 PM, John Hubbard wrote:
> On 2/6/26 10:43 AM, Timur Tabi wrote:
>> On Thu, 2026-02-05 at 20:21 -0800, John Hubbard wrote:
>>> +        // Reset and boot GSP before SEC2
>>> +        gsp_falcon.reset(bar)?;
>>> +        let libos_handle = libos.dma_handle();
>>> +        let (mbox0, mbox1) = gsp_falcon.boot(
>>> +            bar,
>>> +            Some(libos_handle as u32),
>>> +            Some((libos_handle >> 32) as u32),
>>> +        )?;
>>> +        dev_dbg!(dev, "GSP MBOX0: {:#x}, MBOX1: {:#x}\n", mbox0, mbox1);
>>> +        dev_dbg!(
>>> +            dev,
>>> +            "Using SEC2 to load and run the booter_load firmware...\n"
>>> +        );
>>> +
>>
>> Looks like you accidentally deleted the "if mbox0 != 0" test.
>>
> 
> OK, I've added it back in for the next version:
> ...

ah, *correction*, I spoke too quickly. The reason I removed any
such checks at some point is that they are wrong. This mailbox
contains the libos address after boot, not an error code.

Open RM also does not check.

thanks,
-- 
John Hubbard