[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <w3vmcgeh5bw7lfuyv7ziiw3oxpxtjyqmojddamjo5alz4nv7ld@ytgjwdhecfua>
Date: Mon, 9 Feb 2026 14:47:52 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Yongxing Mou <yongxing.mou@....qualcomm.com>
Cc: Vinod Koul <vkoul@...nel.org>, Neil Armstrong <neil.armstrong@...aro.org>,
linux-arm-msm@...r.kernel.org, linux-phy@...ts.infradead.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] phy: qcom: edp: Correct and clean up eDP/DP combo
PHY configuration values
On Mon, Feb 09, 2026 at 05:52:22PM +0800, Yongxing Mou wrote:
>
>
> On 2/7/2026 6:22 PM, Dmitry Baryshkov wrote:
> > On Thu, Feb 05, 2026 at 05:20:53PM +0800, Yongxing Mou wrote:
> > > According to the current HPG settings, most eDP/DP combo PHYs can reuse the
> > > same configuration values.
> > > DP mode:
> > > -sa8775p/sc7280/sc8280xp/x1e80100
> > > -glymur
> > > eDP mode(low vdiff):
> > > -glymur/sa8775p/sc8280xp/x1e80100
> > > -sc7280
> > > The current driver still keeps multiple versions of these tables and
> > > doesn't fully support every combo PHY mode. This patch removes the
> >
> > See Documentation/process/submitting-patches.rst, "This patch".
> >
> Sure. got it thanks, will remove "This patch".
> > > redundant configs and keeps only the sets we actually use, matching the
> > > platforms listed above.
> >
> > Should it be combined with the 3rd patch? There you sort out all the
> > tables, it makes more sense to review all programming together.
> >
> Hi, if this would help with your review work, I’m very happy to do it.
> My original intention was to do some cleanup in this patch—correct the table
> values so that more platforms can reuse the same table.
Fixed should come before cleanups (so that they can be backported to
stable kernels).
> From Konard’s comments, it seems that the HPG table may not be the most
> appropriate one either.
> Maybe shoud first determine what the correct table values should be.
Please follow the tables for each SKU separately (that's the 'fix'
part).
--
With best wishes
Dmitry
Powered by blists - more mailing lists