[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAKTNdwGSYcD430zcuD=z=o5=pRDDvZtDNSY8SYtnyiuUB8r2Bw@mail.gmail.com>
Date: Mon, 9 Feb 2026 19:18:41 +0400
From: Alexey Charkov <alchark@...pper.net>
To: Bean Huo <huobean@...il.com>
Cc: Alim Akhtar <alim.akhtar@...sung.com>, Avri Altman <avri.altman@....com>,
Bart Van Assche <bvanassche@....org>,
"James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
"Martin K. Petersen" <martin.petersen@...cle.com>, Bean Huo <beanhuo@...ron.com>,
Can Guo <can.guo@....qualcomm.com>, linux-scsi@...r.kernel.org,
linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH v2] scsi: ufs: core: Fix RPMB region size detection for
UFS 2.2
On Mon, Feb 9, 2026 at 6:51 PM Bean Huo <huobean@...il.com> wrote:
>
> On Thu, 2026-02-05 at 12:30 +0400, Alexey Charkov wrote:
> > Older UFS spec devices (2.2 and earlier) do not expose per-region RPMB
> > sizes, as only one RPMB region is supported. In such cases, the size of
> > the single RPMB region can be deduced from the Logical Block Count and
> > Logical Block Size fields in the RPMB Unit Descriptor.
> >
> > Add a fallback mechanism to calculate the RPMB region size from these
> > fields if the device implements an older spec, so that the RPMB driver
> > can work with such devices - otherwise it silently skips the whole RPMB.
> >
> > Section 14.1.4.6 (RPMB Unit Descriptor)
> >
> > Link: https://www.jedec.org/system/files/docs/JESD220C-2_2.pdf
> > Cc: stable@...r.kernel.org
> > Fixes: b06b8c421485 ("scsi: ufs: core: Add OP-TEE based RPMB driver for UFS
> > devices")
> > Signed-off-by: Alexey Charkov <alchark@...pper.net>
>
> Hi Alexey,
>
> please address Bart's suggestion in the next version, and add my reviewed tag.
>
> Reviewed-by: Bean Huo <beanhuo@...ron.com>
Thanks Bean! Added in v3, along with the fixed comment per Bart's feedback.
Best regards,
Alexey
Powered by blists - more mailing lists