linux-kernel - Re: [PATCH] platform/x86: lenovo-wmi-{capdata,other}: Fix HWMON channel visibility

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <177073701772.1935.17832144626573387865.b4-ty@linux.intel.com>
Date: Tue, 10 Feb 2026 17:23:37 +0200
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Mark Pearson <mpearson-lenovo@...ebb.ca>, 
 "Derek J. Clark" <derekjohn.clark@...il.com>, Armin Wolf <W_Armin@....de>, 
 Hans de Goede <hansg@...nel.org>, Rong Zhang <i@...g.moe>
Cc: Guenter Roeck <linux@...ck-us.net>, platform-driver-x86@...r.kernel.org, 
 linux-kernel@...r.kernel.org, linux-hwmon@...r.kernel.org
Subject: Re: [PATCH] platform/x86: lenovo-wmi-{capdata,other}: Fix HWMON
 channel visibility

On Sun, 08 Feb 2026 01:23:27 +0800, Rong Zhang wrote:

> The LWMI_SUPP_MAY_{GET,SET} macros are fundamentally broken. When I
> introduced them, I meant to check LWMI_SUPP_VALID *and* the
> corresponding bits for get/set capabilities. However, `supported &
> LWMI_SUPP_MAY_{GET,SET}' means *or*, so it accidentally passes the check
> when LWMI_SUPP_VALID is set.
> 
> Fix them by only including the corresponding get/set bit without
> LWMI_SUPP_VALID. Meanwhile, rename them to LWMI_SUPP_{GET,SET} to make
> them less confusing.
> 
> [...]

Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86: lenovo-wmi-{capdata,other}: Fix HWMON channel visibility
      commit: 5a5203a45b063a594e89a2aeaf9e4923893a5b4c

--
 i.