linux-kernel - Re: [PATCH v2 2/2] xfs: add static size checks for ioctl UABI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260210153559.GB31245@lst.de>
Date: Tue, 10 Feb 2026 16:35:59 +0100
From: Christoph Hellwig <hch@....de>
To: Wilfred Mallawa <wilfred.opensource@...il.com>
Cc: Carlos Maiolino <cem@...nel.org>,
	"Darrick J . Wong" <djwong@...nel.org>, linux-xfs@...r.kernel.org,
	linux-kernel@...r.kernel.org, Christoph Hellwig <hch@....de>,
	Wilfred Mallawa <wilfred.mallawa@....com>
Subject: Re: [PATCH v2 2/2] xfs: add static size checks for ioctl UABI

On Tue, Feb 10, 2026 at 03:59:44PM +1000, Wilfred Mallawa wrote:
> From: Wilfred Mallawa <wilfred.mallawa@....com>
> 
> The ioctl structures in libxfs/xfs_fs.h are missing static size checks.
> It is useful to have static size checks for these structures as adding
> new fields to them could cause issues (e.g. extra padding that may be
> inserted by the compiler). So add these checks to xfs/xfs_ondisk.h.
> 
> Due to different padding/alignment requirements across different
> architectures, to avoid build failures, some structures are ommited from
> the size checks. For example, structures with "compat_" definitions in
> xfs/xfs_ioctl32.h are ommited.

Looks good:

Reviewed-by: Christoph Hellwig <hch@....de>

I couldn't spot any whitespace issues either, although I'd personally
drop the last empty line if I had to nitpick.