linux-kernel - RE: [PATCH 5/8] perf/arm_cspmu: nvidia: Add Tegra410 PCIE-TGT PMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SJ0PR12MB567646CFC7CBB6F114ACDAFDA062A@SJ0PR12MB5676.namprd12.prod.outlook.com>
Date: Tue, 10 Feb 2026 16:01:45 +0000
From: Besar Wicaksono <bwicaksono@...dia.com>
To: Ilkka Koskinen <ilkka@...amperecomputing.com>
CC: "will@...nel.org" <will@...nel.org>, "suzuki.poulose@....com"
	<suzuki.poulose@....com>, "robin.murphy@....com" <robin.murphy@....com>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-tegra@...r.kernel.org"
	<linux-tegra@...r.kernel.org>, "mark.rutland@....com" <mark.rutland@....com>,
	Thierry Reding <treding@...dia.com>, Jon Hunter <jonathanh@...dia.com>,
	Vikram Sethi <vsethi@...dia.com>, Rich Wiley <rwiley@...dia.com>, Shanker
 Donthineni <sdonthineni@...dia.com>, Sean Kelley <skelley@...dia.com>, Yifei
 Wan <YWan@...dia.com>, Matt Ochs <mochs@...dia.com>, Nirmoy Das
	<nirmoyd@...dia.com>
Subject: RE: [PATCH 5/8] perf/arm_cspmu: nvidia: Add Tegra410 PCIE-TGT PMU



> -----Original Message-----
> From: Ilkka Koskinen <ilkka@...amperecomputing.com>
> Sent: Thursday, January 29, 2026 4:40 PM
> To: Besar Wicaksono <bwicaksono@...dia.com>
> Cc: will@...nel.org; suzuki.poulose@....com; robin.murphy@....com;
> ilkka@...amperecomputing.com; linux-arm-kernel@...ts.infradead.org; linux-
> kernel@...r.kernel.org; linux-tegra@...r.kernel.org; mark.rutland@....com;
> Thierry Reding <treding@...dia.com>; Jon Hunter <jonathanh@...dia.com>;
> Vikram Sethi <vsethi@...dia.com>; Rich Wiley <rwiley@...dia.com>; Shanker
> Donthineni <sdonthineni@...dia.com>; Sean Kelley <skelley@...dia.com>;
> Yifei Wan <ywan@...dia.com>; Matt Ochs <mochs@...dia.com>; Nirmoy Das
> <nirmoyd@...dia.com>
> Subject: Re: [PATCH 5/8] perf/arm_cspmu: nvidia: Add Tegra410 PCIE-TGT
> PMU
> 
> External email: Use caution opening links or attachments
> 
> 
> Hi Besar,
> 
> On Mon, 26 Jan 2026, Besar Wicaksono wrote:
> > Adds PCIE-TGT PMU support in Tegra410 SOC.
> >
> > Signed-off-by: Besar Wicaksono <bwicaksono@...dia.com>
> > ---
> > .../admin-guide/perf/nvidia-tegra410-pmu.rst  |  76 ++++
> > drivers/perf/arm_cspmu/nvidia_cspmu.c         | 324 ++++++++++++++++++
> > 2 files changed, 400 insertions(+)
> >
> > diff --git a/drivers/perf/arm_cspmu/nvidia_cspmu.c
> b/drivers/perf/arm_cspmu/nvidia_cspmu.c
> > index 3a5531d1f94c..095d2f322c6f 100644
> > --- a/drivers/perf/arm_cspmu/nvidia_cspmu.c
> > +++ b/drivers/perf/arm_cspmu/nvidia_cspmu.c
> 
> <snip>
> 
> > +static void pcie_tgt_pmu_reset_ev_filter(struct arm_cspmu *cspmu,
> > +                                  const struct perf_event *event)
> > +{
> > +     bool addr_filter_en;
> > +     u64 base, mask;
> > +     int idx;
> > +
> > +     addr_filter_en = pcie_tgt_pmu_addr_en(event);
> > +     if (!addr_filter_en)
> > +             return;
> > +
> > +     base = pcie_tgt_pmu_dst_addr_base(event);
> > +     mask = pcie_tgt_pmu_dst_addr_mask(event);
> > +     idx = pcie_tgt_find_addr_idx(cspmu, base, mask, true);
> > +
> > +     if (idx < 0) {
> > +             dev_err(cspmu->dev,
> > +                     "Unable to find the address filter slot to reset\n");
> > +             return;
> > +     }
> > +
> > +     pcie_tgt_pmu_config_addr_filter(
> > +                     cspmu, false, base, mask, idx);
> 
> I think you can fit the arguments in the same line with the function name
> 
> Otherwise, looks good to me.
> 
>         Reviewed-by: Ilkka Koskinen <ilkka@...amperecomputing.com>
> 
> Cheers, Ilkka
> 

Thanks Ilkka. I will incorporate your comments (on the other patches as well)
on V2.

Regards,
Besar