linux-kernel - Re: [PATCH v6 RESEND 1/3] x86/mm/tlb: Make enter_lazy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bb662280-1223-44e0-8be1-d0f0cf453e9e@intel.com>
Date: Tue, 10 Feb 2026 08:07:38 -0800
From: Dave Hansen <dave.hansen@...el.com>
To: Xie Yuanbin <qq570070308@...il.com>, peterz@...radead.org,
 tglx@...nel.org, riel@...riel.com, segher@...nel.crashing.org,
 david@...nel.org, hpa@...or.com, arnd@...db.de, anna-maria@...utronix.de,
 mingo@...hat.com, juri.lelli@...hat.com, vincent.guittot@...aro.org,
 dietmar.eggemann@....com, rostedt@...dmis.org, bsegall@...gle.com,
 mgorman@...e.de, vschneid@...hat.com, bp@...en8.de,
 dave.hansen@...ux.intel.com, luto@...nel.org, houwenlong.hwl@...group.com,
 frederic@...nel.org, akpm@...ux-foundation.org, lorenzo.stoakes@...cle.com,
 bhe@...hat.com, ryan.roberts@....com, urezki@...il.com, nysal@...ux.ibm.com,
 max.kellermann@...os.com
Cc: linux-kernel@...r.kernel.org, x86@...nel.org
Subject: Re: [PATCH v6 RESEND 1/3] x86/mm/tlb: Make enter_lazy_tlb() always
 inline on x86

On 2/10/26 07:32, Xie Yuanbin wrote:
> This was just to fix a compilation error:
> 'cpu_tlbstate' is defined in 'include/asm/tlbflush.h' inside of
> '#ifndef MODULE'. So if the '#ifndef MODULE' is not added here,
> the compilation error will be triggered:

Rather than sprinkling #ifdefs and 'cpu_tlbstate' references around,
could we try to keep them confined to asm/tlbflush.h as much as
possible, please?

I mean, mmu_context.h _does_ include asm/tlbflush.h, so even if you
stuck enter_lazy_tlb() in asm/tlbflush.h, everything should keep
working, no?

That would both prevent adding a random #ifdef and keep 'cpu_tlbstate'
references limited.