linux-kernel - Re: [PATCH v2] drm/panel: jdi-lt070me05000: Use MIPI DSI multi functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD=FV=W4p_GdKL50cz3hgSpntWJNCnObF1C6B8eskeVuRc+otQ@mail.gmail.com>
Date: Tue, 10 Feb 2026 08:47:31 -0800
From: Doug Anderson <dianders@...omium.org>
To: Chintan Patel <chintanlike@...il.com>
Cc: neil.armstrong@...aro.org, jesszhan0024@...il.com, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] drm/panel: jdi-lt070me05000: Use MIPI DSI multi functions

Hi,

On Tue, Feb 3, 2026 at 7:14 PM Doug Anderson <dianders@...omium.org> wrote:
>
> Hi,
>
> On Mon, Feb 2, 2026 at 8:46 PM Chintan Patel <chintanlike@...il.com> wrote:
> >
> > Convert to the non-deprecated mipi_dsi_*_multi() helpers per the TODO
> > list. This reduces boilerplate error checking while providing proper
> > error accumulation.
> >
> > Use mipi_dsi_msleep() and mipi_dsi_usleep_range() macros for delays.
> > Replace mdelay(10) and mdelay(20) with mipi_dsi_usleep_range() calls
> > using tighter slop (10-11ms and 20-21ms respectively) since these
> > functions aren't run often and don't need large timing windows.
> >
> > In jdi_panel_off(), reset the error context between display_off and
> > enter_sleep_mode to preserve the original behavior of continuing power-down
> > even if display_off fails. This ensures enter_sleep_mode executes before
> > GPIO/regulator control, which is critical for proper power sequencing.
> >
> > Signed-off-by: Chintan Patel <chintanlike@...il.com>
> > ---
> >
> > Changes in v2:
> > - Replaced mdelay() with mipi_dsi_usleep_range() for timing (tighter bounds per review)
> > - Switched to mipi_dsi_generic_write_seq_multi() for cleaner varargs syntax
> > - Applied lowercase hex notation per kernel style guide
> > - Added error accumulator reset in jdi_panel_off() to preserve power-down behavior
> > - Kept final msleep(100) outside multi context for safety
> >
> >  .../gpu/drm/panel/panel-jdi-lt070me05000.c    | 105 ++++--------------
> >  1 file changed, 24 insertions(+), 81 deletions(-)
>
> This looks nice to me now, and I think it's a nice improvement to the driver.
>
> Reviewed-by: Douglas Anderson <dianders@...omium.org>
>
> I'll put it in my queue and plan to land it next week unless someone
> beats me to it or has additional comments.

Pushed to drm-misc-next. Thanks!

[1/1] drm/panel: jdi-lt070me05000: Use MIPI DSI multi functions
      commit: 857e2d886ad32d9a49fe99fd06bd78f4354043f4