linux-kernel - Re: [PATCH v2] staging: rtl8723bs: remove shadowed variable in sdio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DGBHWOGRN39L.17RRNUN1O5YX1@gmail.com>
Date: Tue, 10 Feb 2026 12:32:44 -0600
From: "Ethan Tidmore" <ethantidmore06@...il.com>
To: "Haroen Tmimi" <tmimiharoen@...il.com>, <gregkh@...uxfoundation.org>
Cc: <linux-staging@...ts.linux.dev>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] staging: rtl8723bs: remove shadowed variable in
 sdio_halinit

On Tue Feb 10, 2026 at 11:04 AM CST, Haroen Tmimi wrote:
> The variable 'bMacPwrCtrlOn' was redeclared in the function
> CardEnable, shadowing a variable of the same name declared at the
> top of the function (line 21).
>
> Remove the redundant 'u8' type declaration to use the existing outer
> variable and resolve a -Wshadow warning.
>
> Signed-off-by: Haroen Tmimi <tmimiharoen@...il.com>
> ---
> Changes in v2:
> Removed incorrect blank line after the opening brace that was left
> behind when removing the Adapter variable.
>
>  drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c | 1 -
>  drivers/staging/rtl8723bs/hal/sdio_halinit.c   | 2 +-
>  2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
> index f712d0345b99..0f915589b518 100644
> --- a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
> +++ b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
> @@ -208,7 +208,6 @@ void ODM_TxPwrTrackSetPwr_8723B(
>  	}
>  
>  	if (Method == TXAGC) {
> -
>  		pDM_Odm->Remnant_OFDMSwingIdx[RFPath] = pDM_Odm->Absolute_OFDMSwingIdx[RFPath];
>  
>  		pDM_Odm->Modify_TxAGC_Flag_PathA = true;

It looks like you accidently left your previous diff in this patch.

Thanks,

ET