lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <DGBID683QZLL.275K62PPUD5D8@gmail.com>
Date: Tue, 10 Feb 2026 12:54:16 -0600
From: "Ethan Tidmore" <ethantidmore06@...il.com>
To: "Haroen Tmimi" <tmimiharoen@...il.com>, <gregkh@...uxfoundation.org>
Cc: <linux-staging@...ts.linux.dev>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] staging: rtl8723bs: remove explicit comparisons to
 false in rtw_ap.c

On Tue Feb 10, 2026 at 10:16 AM CST, Haroen Tmimi wrote:
> Fix checkpatch.pl checks regarding error prone boolean comparisons.
> Replace explicit comparisons to false with the logical NOT operator
> to improve readability and match kernel coding style.
>
> These instances were remaining after recent cleanups in this file.
>
> Signed-off-by: Haroen Tmimi <tmimiharoen@...il.com>

Please slow down, there is no rush here. Wait 24h between submitting
revisions. This gives a chance for other people to review your code.

LGTM.

Reviewed-by: Ethan Tidmore <ethantidmore06@...il.com>

Thanks,

ET

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ