linux-kernel - Re: [PATCH 1/1] tools build: Fix rust feature detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <hox364wgs57bv7hvscvvtbkl5yerur55iz7un3gsu3ozpbnba5@haqvngx6jy4n>
Date: Tue, 10 Feb 2026 21:16:18 +0100
From: Dmitry Dolgov <9erthalion6@...il.com>
To: Arnaldo Carvalho de Melo <acme@...nel.org>
Cc: Adrian Hunter <adrian.hunter@...el.com>, 
	Ian Rogers <irogers@...gle.com>, James Clark <james.clark@...aro.org>, 
	Jiri Olsa <jolsa@...nel.org>, Namhyung Kim <namhyung@...nel.org>, 
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, linux-perf-users@...r.kernel.org
Subject: Re: [PATCH 1/1] tools build: Fix rust feature detection

> On Tue, Feb 10, 2026 at 09:26:22AM -0300, Arnaldo Carvalho de Melo wrote:
> I tried here building it with rust installed, it detected, ok, then I
> removed and tried to rebuild, it still thinks rust is there:
> 
> [...]
>
> I.e. it doesn't rebuild perf and thus doesn't notice that it doesn't
> have what is needed, if I touch some other file and thus it triggers a
> rebuild, it still manages to build it...

Yeah, looks like the problem is due to rust not adding any actual depedencies
into the dep-info file, when compiling the feature test file:

	/perf/feature/test-rust.d: test-rust.rs

	/perf/feature/test-rust.bin: test-rust.rs

	test-rust.rs:

To fix that I've tried to add an extra dependency on the rust binary on top of
that after the compilation is finished. While hacky, it worked just fine, and
perf catched it when rust was removed. Haven't faced any issues after few
rounds of installing/removing rust either. If this approach sound fine, I can
post the patch tomorrow.