linux-kernel - Re: [PATCH 2/2] iio: light: vcnl4000: add support for Capella CM36686 and CM36672P

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Veczn--S=G0iEyUOnVYZ5rT+F_Sw1=6YOo=ynPiKPHF6w@mail.gmail.com>
Date: Tue, 10 Feb 2026 22:53:56 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Erikas Bitovtas <xerikasxx@...il.com>
Cc: Jonathan Cameron <jic23@...nel.org>, David Lechner <dlechner@...libre.com>, 
	Nuno Sá <nuno.sa@...log.com>, 
	Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Peter Meerwald <pmeerw@...erw.net>, linux-iio@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht, 
	phone-devel@...r.kernel.org
Subject: Re: [PATCH 2/2] iio: light: vcnl4000: add support for Capella CM36686
 and CM36672P

On Tue, Feb 10, 2026 at 10:46 PM Erikas Bitovtas <xerikasxx@...il.com> wrote:
>
> Add support for Capella's CM36686 and CM36672P sensors. Capella
> CM36686 is an ambient light and proximity sensor that is fully
> compatible with VCNL4040 and can be used as is. For CM36672P, which is
> a proximity-only sensor, also remove the IIO_LIGHT channel.

A couple of nit-picks, otherwise LGTM (much better than the first
version!), thanks.

...

>         { "vcnl4020", VCNL4010 },
>         { "vcnl4040", VCNL4040 },
>         { "vcnl4200", VCNL4200 },
> +       { "cm36672p", CM36672P },
> +       { "cm36686", VCNL4040 },

Keep it ordered by device name (string literal).

...

> +static const struct iio_chan_spec cm36672p_channels[] = {
> +       {
> +               .type = IIO_PROXIMITY,
> +               .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) |
> +                       BIT(IIO_CHAN_INFO_INT_TIME) |
> +                       BIT(IIO_CHAN_INFO_OVERSAMPLING_RATIO) |
> +                       BIT(IIO_CHAN_INFO_CALIBBIAS),
> +               .info_mask_separate_available = BIT(IIO_CHAN_INFO_INT_TIME) |
> +                       BIT(IIO_CHAN_INFO_OVERSAMPLING_RATIO) |
> +                       BIT(IIO_CHAN_INFO_CALIBBIAS),
> +               .ext_info = vcnl4000_ext_info,
> +               .event_spec = vcnl4040_event_spec,
> +               .num_event_specs = ARRAY_SIZE(vcnl4040_event_spec),

> +       }

Keep trailing comma when it's not a terminator entry.

> +};

-- 
With Best Regards,
Andy Shevchenko